From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with UTF8SMTPS id 9117B750E3 for ; Wed, 21 Apr 2021 08:50:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with UTF8SMTP id 85BB0B8FB for ; Wed, 21 Apr 2021 08:50:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with UTF8SMTPS id ACC8DB8ED for ; Wed, 21 Apr 2021 08:50:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with UTF8SMTP id 8597244173; Wed, 21 Apr 2021 08:50:16 +0200 (CEST) Message-ID: <3ffe2d5b-f4b5-10a1-ad5a-bdc109f6590a@proxmox.com> Date: Wed, 21 Apr 2021 08:50:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101 Thunderbird/88.0 Content-Language: en-US To: Thomas Lamprecht , Proxmox VE development discussion References: <20210420143545.11022-1-d.csapak@proxmox.com> <2f09aba4-2cd2-8200-1bfd-427a11100672@proxmox.com> From: Dominik Csapak In-Reply-To: <2f09aba4-2cd2-8200-1bfd-427a11100672@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.001 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] applied: [PATCH manager] ui: qemu/Config: disable xtermjs and spice until status is loaded X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Apr 2021 06:50:20 -0000 On 4/20/21 18:20, Thomas Lamprecht wrote: > On 20.04.21 16:35, Dominik Csapak wrote: >> We enable/disable spice/xtermjs for the console button in the 'load' >> callback of the statusstore, depending on the vms capabilities, >> but until the first load there, the only safe option is novnc. >> >> So we have to disable xtermjs and spice on start, else a click on >> the button might open a window that cannot connect to the vm. >> >> a forum user probably triggered this: >> https://forum.proxmox.com/threads/unable-to-find-serial-interface-console-problem.87705 >> >> Signed-off-by: Dominik Csapak >> --- >> www/manager6/qemu/Config.js | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/www/manager6/qemu/Config.js b/www/manager6/qemu/Config.js >> index 10bf10a4..b5f8cc9c 100644 >> --- a/www/manager6/qemu/Config.js >> +++ b/www/manager6/qemu/Config.js >> @@ -199,6 +199,8 @@ Ext.define('PVE.qemu.Config', { >> disabled: !caps.vms['VM.Console'], >> hidden: template, >> consoleType: 'kvm', >> + enableSpice: false, >> + enableXtermjs: false, >> consoleName: vm.name, >> nodename: nodename, >> vmid: vmid, >> > > adding a comment could be nice to avoid people thinking to "clean this up" in the future. yes, i'll add a comment > > Anyway, applied. Related in the widest sense: > > I have an issue with the default opened console viewer, a VM always opens the xtermjs > one when IMO the spice viewer or noVNC one should be preferred. > > Setup details > > * windows VM > ** display spice (qxl) > ** serial port added > * datacenter options for console viewer set to html5 > weird, works for me differently: * datacenter html5 * vm with display spice + serial port * opens novnc i'll investigate