From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id B50981FF56B
for <inbox@lore.proxmox.com>; Mon, 22 Apr 2024 15:18:51 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 0D90512852;
Mon, 22 Apr 2024 15:18:55 +0200 (CEST)
Message-ID: <3ff3ecf6-08b5-49fb-8d6f-84448ff32b78@proxmox.com>
Date: Mon, 22 Apr 2024 15:18:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>, Markus Frank <m.frank@proxmox.com>
References: <20240415085002.665246-1-m.frank@proxmox.com>
<20240415085002.665246-2-m.frank@proxmox.com>
<2d790314-0973-4cf1-937e-00041cf8b0bf@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <2d790314-0973-4cf1-937e-00041cf8b0bf@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.015 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH manager v10 2/2] ui: machine: add link to
documentation of the system settings
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On 4/22/24 15:13, Fiona Ebner wrote:
> Am 15.04.24 um 10:50 schrieb Markus Frank:
>> ---
>> www/manager6/qemu/MachineEdit.js | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/www/manager6/qemu/MachineEdit.js b/www/manager6/qemu/MachineEdit.js
>> index 48c72c1d..ee2b2dac 100644
>> --- a/www/manager6/qemu/MachineEdit.js
>> +++ b/www/manager6/qemu/MachineEdit.js
>> @@ -1,6 +1,7 @@
>> Ext.define('PVE.qemu.MachineInputPanel', {
>> extend: 'Proxmox.panel.InputPanel',
>> xtype: 'pveMachineInputPanel',
>> + onlineHelp: 'qm_system_settings',
>>
>
> Why not the more accurate 'qm_machine_type' (was introduced in pve-docs
>> = 8.1.0)?
>
>
you're right, would be even better (did not realize that existed), i/you can send/push a follow up?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel