From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 142B26196B for ; Thu, 9 Jul 2020 20:07:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EBA9214BDC for ; Thu, 9 Jul 2020 20:06:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2078514BBF for ; Thu, 9 Jul 2020 20:06:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B97B7444AB for ; Thu, 9 Jul 2020 20:06:42 +0200 (CEST) To: PVE development discussion , Aaron Lauterer , pve-devel@pve.proxmox.com References: <20200707094902.24712-1-a.lauterer@proxmox.com> From: Thomas Lamprecht Message-ID: <3f55f4f3-da61-5a79-e9c5-b196a4c397fc@proxmox.com> Date: Thu, 9 Jul 2020 20:06:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.0 MIME-Version: 1.0 In-Reply-To: <20200707094902.24712-1-a.lauterer@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied-series: Re: [PATCH v4 manager 0/5] add backup detail and not backed up view X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2020 18:07:15 -0000 On 07.07.20 11:48, Aaron Lauterer wrote: > This series add a new detail view for backup jobs to show which volumes > of a guest would be included. > > Additionally it adds a notification if there are any guests not covered > by any backup job with a new window showing these guests. This is to fix > #2609. > > For the latter, a new API endpoint was needed because the already > existing `cluster/backup` expects a job ID on the next level. This makes > it hard to impossible to add other endpoints there. More details are in > the actual patch. > > > Changes from v3 -> v4: > > * switched from summary view with its own button to notification if some > guests are not backed up and changed the view to only include not > backed up guests. > * added search boxes to both the detail tree view > * removed the "not permissions for all" notification. We don't do that > anywhere else anyway and it makes the API return structure simpler and > easier to deal with > * incorporated some code style changes such as creating the object to be > pushed to the result array inline in the push operation instead of > defining it way before > > > Aaron Lauterer (5): > api: backup: add endpoint to list included guests and volumes > gui: dc/backup: move renderers to Utils.js > gui: dc/backup: add new backup job detail view > fix #2609 api: backupinfo: add non job specific endpoint > fix #2609 gui: backup: add window for not backed guests > > PVE/API2/Backup.pm | 174 ++++++++++++ > PVE/API2/BackupInfo.pm | 145 ++++++++++ > PVE/API2/Cluster.pm | 6 + > PVE/API2/Makefile | 1 + > www/manager6/Utils.js | 94 +++++++ > www/manager6/dc/Backup.js | 574 ++++++++++++++++++++++++++++++++++---- > 6 files changed, 936 insertions(+), 58 deletions(-) > create mode 100644 PVE/API2/BackupInfo.pm > applied series, thanks! FYI: Slightly adapted default window size, renamed "Detail" button to "Job Detail" moved the Job Detail and moved it's search to the panel header to save some vertical space.