From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6D5EA85A3B for <pve-devel@lists.proxmox.com>; Mon, 20 Dec 2021 20:38:06 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5C19821998 for <pve-devel@lists.proxmox.com>; Mon, 20 Dec 2021 20:37:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9FDCC2198A for <pve-devel@lists.proxmox.com>; Mon, 20 Dec 2021 20:37:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6CFDC44F2C for <pve-devel@lists.proxmox.com>; Mon, 20 Dec 2021 20:37:35 +0100 (CET) Message-ID: <3f42d312-9021-5d83-6e8b-92c07dcb10d8@proxmox.com> Date: Mon, 20 Dec 2021 20:37:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101 Thunderbird/96.0 Content-Language: en-GB To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Aaron Lauterer <a.lauterer@proxmox.com> References: <20211220153839.537253-1-a.lauterer@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20211220153839.537253-1-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.873 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.608 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH futter_frontend 1/2] fix android splash screen logo X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 20 Dec 2021 19:38:06 -0000 On 20/12/2021 16:38, Aaron Lauterer wrote: > The new splash screen that came with Android 12 has stricter rules > regarding the size and form of the logo in the splash screen [0]. oh, do you have an actual reference to the strict rules you found, as [0] As I read [0] quite closely and basically all mentions regarding the drawable are IMO the opposite of strict, e.g.: > The app icon (1) should be a vector drawable, and it can be static or animated. And all other references are similarly vague and imply multiple times that any drawable should work. > > We do need to have a drawable that is a square with the logo / icon in > the center. That means the current approach with the png image resulted > in it being scaled to the full width and the circular mask cut if off. hmm, the bitmap used sets `android:gravity` to `center` though, which is documented as: > Place the object in the center of its container in both the vertical and > horizontal axis, not changing its size. -- https://developer.android.com/guide/topics/resources/drawable-resource#XmlBitmap > The result was a broken looking splash screen. FWIW, I only run into the following issue: https://issuetracker.google.com/issues/207095799#comment10 > > I opted for the stacked variant of the logo and saved it as a vector > drawable in the xml format that android wants. > > [0] https://developer.android.com/guide/topics/ui/splash-screen > > Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com> > --- > .../main/res/drawable/proxmox_splash_logo.xml | 69 +++++++++++++++++++ > .../app/src/main/res/values-night/styles.xml | 2 +- > android/app/src/main/res/values/styles.xml | 2 +- > 3 files changed, 71 insertions(+), 2 deletions(-) > create mode 100644 android/app/src/main/res/drawable/proxmox_splash_logo.xml >