From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 359A173A1E for ; Fri, 18 Jun 2021 18:00:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 24F39A8EA for ; Fri, 18 Jun 2021 18:00:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 02B4DA8DA for ; Fri, 18 Jun 2021 17:59:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C85F9441DD for ; Fri, 18 Jun 2021 17:59:58 +0200 (CEST) Message-ID: <3f3c0b6c-ab9d-e8e4-abab-ff77770ccb61@proxmox.com> Date: Fri, 18 Jun 2021 17:59:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion , Oguz Bektas References: <20210617105201.804786-1-o.bektas@proxmox.com> <20210617105201.804786-2-o.bektas@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210617105201.804786-2-o.bektas@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.904 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.254 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [setup.pm] Subject: Re: [pve-devel] [PATCH v5 container 1/4] setup: add post_clone_hook for containers X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2021 16:00:30 -0000 On 17.06.21 12:51, Oguz Bektas wrote: > --- a/src/PVE/LXC/Setup.pm > +++ b/src/PVE/LXC/Setup.pm > @@ -352,6 +352,18 @@ sub pre_start_hook { > $self->protected_call($code); > } > > +sub post_clone_hook { > + my ($self, $conf) = @_;> + > + my $clone = 1; what is with this parameter? The post_clone_hook does not have it in it's signature and it does not look like it would be useful in general... > + > + my $code = sub { > + $self->{plugin}->post_clone_hook($self->{conf}, $clone); why pass $conf if then $self->{conf} is passed to the actual hook, leaving $conf unused? > + }; > + $self->protected_call($code); > + > +} > + > sub post_create_hook { > my ($self, $root_password, $ssh_keys) = @_; >