From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A8B1C1FF15F for ; Mon, 9 Sep 2024 09:42:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D5CD0E485; Mon, 9 Sep 2024 09:43:06 +0200 (CEST) Message-ID: <3eea2a77-5e33-4e24-9c8c-3f4ba9eb9200@proxmox.com> Date: Mon, 9 Sep 2024 09:42:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Daniel Kral References: <20240723152548.129832-11-f.ebner@proxmox.com> <20240906143932.239510-1-d.kral@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20240906143932.239510-1-d.kral@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server 10/10] test: cfg2cmd: don't use QEMU binary version less than 8.0 for tests X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 06.09.24 um 16:39 schrieb Daniel Kral: > Another small misspelling that could be corrected here: > > s/depreacation/deprecation > > On Tue, 23 Jul 2024 17:25:40 +0200, Fiona Ebner wrote: >> diff --git a/test/cfg2cmd/cputype-icelake-client-deprecation.conf b/test/cfg2cmd/cputype-icelake-client-deprecation.conf >> index 523dd275..2f595162 100644 >> --- a/test/cfg2cmd/cputype-icelake-client-deprecation.conf >> +++ b/test/cfg2cmd/cputype-icelake-client-deprecation.conf >> @@ -1,5 +1,4 @@ >> # TEST: test CPU type depreacation for Icelake-Client (never existed in the wild) > > Otherwise, I haven't found anything to add to the changes and the test > cases are all passing on my machine as expected. > > Therefore: > > Reviewed-by: Daniel Kral > Tested-by: Daniel Kral > Thank you for the review/testing! Note (for the future): If the tags here are supposed to be for the whole series, it would be customary to add them in a reply to the cover letter. Feel free to send patches for the pre-existing typos you found. You might want to wait until my series got applied to avoid merge-conflicts. If there's going to be a v2 of my series for some reason, I can also add them as follow-ups myself. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel