From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BCBDD1FF13F for ; Thu, 12 Mar 2026 09:30:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CD0368561; Thu, 12 Mar 2026 09:30:30 +0100 (CET) Message-ID: <3eaa05d4-e305-4f54-b1c1-2f5e7bd2adcc@proxmox.com> Date: Thu, 12 Mar 2026 09:30:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-ve-rs v5 8/8] frr: add bgp support with templates and serialization To: Gabriel Goller , pve-devel@lists.proxmox.com References: <20260310120705.150425-1-g.goller@proxmox.com> <20260310120705.150425-9-g.goller@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: <20260310120705.150425-9-g.goller@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773304191173 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.997 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CG6CNYD2XPA6YIEUSMTULTMVA6GJQ3FE X-Message-ID-Hash: CG6CNYD2XPA6YIEUSMTULTMVA6GJQ3FE X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-03-10 13:08, Gabriel Goller wrote: > Implements bgp routing configuration (rust types and templates) > including routers, neighbor groups, address families (IPv4/IPv6 unicast, > L2VPN EVPN), VRFs, route redistribution, and prefix lists. > > Co-authored-by: Stefan Hanreich > Signed-off-by: Gabriel Goller > --- [..] > diff --git a/proxmox-frr-templates/templates/bgpd.jinja b/proxmox-frr-templates/templates/bgpd.jinja > new file mode 100644 > index 000000000000..cdd0a50abf8c > --- /dev/null > +++ b/proxmox-frr-templates/templates/bgpd.jinja > @@ -0,0 +1,35 @@ > +{% from "bgp_router.jinja" import bgp_router %} > +{% for vrf_name, vrf in bgp.vrfs|items %} > +! > +vrf {{ vrf_name }} > +{% if vrf.vni %} ^ > + vni {{ vrf.vni }} I don't we do that currently, but it is possible to have routes in a VRF but no VNI, shouldn't be a problem for us, just wanted to note it > +{% for ip_route in vrf.ip_routes %} > +{% if ip_route.vrf %} > + {{ "ipv6" if ip_route.is_ipv6 else "ip" }} route {{ ip_route.prefix }} {{ ip_route.via }} {{ ip_route.vrf }} > +{% else %} > + {{ "ipv6" if ip_route.is_ipv6 else "ip" }} route {{ ip_route.prefix }} {{ ip_route.via }} > +{% endif %} > +{% endfor %} > +{% endif %} ^ > +{% for line in vrf.custom_frr_config %} > +{{ line }} > +{% endfor %} > +exit-vrf > +{% endfor %} > +{% for vrf_name, router_config in bgp.vrf_router|items %} > +! > +{% if vrf_name == "default" %} > +router bgp {{ router_config.asn }} > +{% else %} > +router bgp {{ router_config.asn }} vrf {{ vrf_name }} > +{% endif %} > +{{ bgp_router(router_config) -}} > +exit > +{% endfor %} > +{% for view_id, router_config in bgp.view_router|items %} > +! > +router bgp {{ router_config.asn }} view {{ view_id }} > +{{ bgp_router(router_config) -}} > +exit > +{% endfor %} [..]