From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B91F972744; Tue, 13 Apr 2021 08:39:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A96C226BB4; Tue, 13 Apr 2021 08:39:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9191A26BA5; Tue, 13 Apr 2021 08:39:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 54D0241D90; Tue, 13 Apr 2021 08:39:20 +0200 (CEST) Message-ID: <3e6c8636-f44a-6c23-b782-d567f2446fff@proxmox.com> Date: Tue, 13 Apr 2021 08:39:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101 Thunderbird/88.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Stefan Reiter , pve-devel@lists.proxmox.com References: <20210412153252.22652-1-s.reiter@proxmox.com> <20210412153252.22652-2-s.reiter@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210412153252.22652-2-s.reiter@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.043 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs] Subject: [pve-devel] applied: [pbs-devel] [PATCH proxmox-backup 2/2] api/datastore: allow pxar file download of entire archive X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Apr 2021 06:39:21 -0000 On 12.04.21 17:32, Stefan Reiter wrote: > Treat filepaths like "/root.pxar.didx" without a trailing slash as > wanting to download the entire archive content instead of erroring. The > zip-creation code already works fine for this scenario. > > Signed-off-by: Stefan Reiter > --- > src/api2/admin/datastore.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! But that API is definitively weird in general... 1. old style API definition, should use the #[api()] macro instead 2. perly "params: Value", yeah, no thanks. 3. hard coded return stream type, one should be able to download also a single file as zip, and we knew that we wanted .tar then too, so not providing an param for that is weird. 4. accessed via /json/ path but never returns json