From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EF12A90C79 for ; Tue, 13 Feb 2024 09:50:28 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D622C32B51 for ; Tue, 13 Feb 2024 09:50:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 13 Feb 2024 09:50:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EFD3547B6F for ; Tue, 13 Feb 2024 09:50:27 +0100 (CET) Message-ID: <3e3b8b22-5ed1-4833-9dcc-02ce52f23cc8@proxmox.com> Date: Tue, 13 Feb 2024 09:50:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: pve-devel@lists.proxmox.com References: <20240205175419.1271680-1-m.carrara@proxmox.com> <20240205175419.1271680-8-m.carrara@proxmox.com> <1707742887.vpjp8ojapl.astroid@yuna.none> From: Max Carrara In-Reply-To: <1707742887.vpjp8ojapl.astroid@yuna.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.421 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_ASCII_DIVIDERS 0.8 Email that uses ascii formatting dividers and possible spam tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v2 pve-storage 07/11] amend! cephconfig: allow writing arbitrary sections X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2024 08:50:29 -0000 On 2/12/24 14:33, Fabian Grünbichler wrote: > On February 5, 2024 6:54 pm, Max Carrara wrote: >> cephconfig: allow writing arbitrary sections >> >> This adds support for writing arbitrary sections to 'ceph.conf' while >> ensuring that already written sections are not duplicated. >> >> Sections that are associated with the client, for example >> '[client.foo]', are written directly after the '[client]' section. >> >> Sections associated with 'mds', 'mon', 'osd' and 'mgr' are also >> written directly after their associated section. >> >> Signed-off-by: Max Carrara >> --- >> NOTE: This amend really just changes the order of the sections below and >> may be dropped if not desired. > > does the order matter at all? the docs would imply that it doesn't, > since there is a clear precedence between [global], [$type], and > [$type.$id] (e.g., global -> client -> client.crash).. No, it doesn't - I perhaps should've worded this a little more clearly; this change is purely cosmetic and just makes it so each '[$type]' is followed by its respective '[$type.$id]'. > > https://docs.ceph.com/en/latest/rados/configuration/ceph-conf/#configuration-sections > >> >> Changes v1 --> v2: >> * new >> >> src/PVE/CephConfig.pm | 11 +++++++---- >> 1 file changed, 7 insertions(+), 4 deletions(-) >> >> diff --git a/src/PVE/CephConfig.pm b/src/PVE/CephConfig.pm >> index 86d3079..00b1f35 100644 >> --- a/src/PVE/CephConfig.pm >> +++ b/src/PVE/CephConfig.pm >> @@ -82,17 +82,20 @@ sub write_ceph_config { >> }; >> >> &$cond_write_sec('global'); >> + >> &$cond_write_sec('client'); >> &$cond_write_sec('client\..*'); >> >> &$cond_write_sec('mds'); >> - &$cond_write_sec('mon'); >> - &$cond_write_sec('osd'); >> - &$cond_write_sec('mgr'); >> - >> &$cond_write_sec('mds\..*'); >> + >> + &$cond_write_sec('mon'); >> &$cond_write_sec('mon\..*'); >> + >> + &$cond_write_sec('osd'); >> &$cond_write_sec('osd\..*'); >> + >> + &$cond_write_sec('mgr'); >> &$cond_write_sec('mgr\..*'); >> >> &$cond_write_sec('.*'); >> -- >> 2.39.2 >> >> >> >> _______________________________________________ >> pve-devel mailing list >> pve-devel@lists.proxmox.com >> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >> >> >> > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >