From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 2F0B11FF37F for ; Thu, 18 Apr 2024 12:20:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1A3371A532; Thu, 18 Apr 2024 12:20:34 +0200 (CEST) Message-ID: <3e189544-8180-4d51-982e-5e59f4cf13cd@proxmox.com> Date: Thu, 18 Apr 2024 12:20:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pve-devel@lists.proxmox.com References: <20240418091650.51366-1-a.zeidler@proxmox.com> <20240418091650.51366-6-a.zeidler@proxmox.com> Content-Language: en-US From: Mira Limbeck In-Reply-To: <20240418091650.51366-6-a.zeidler@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.299 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager 6/7] report: add info about (un)used memory slots X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 4/18/24 11:16, Alexander Zeidler wrote: > * to see if a RAM upgrade is slot/capacity-wise possible > * to spot added/replaced RAM that may now be causing issues > > Maximum Capacity: 2 TB > Size: 16 GB Part Number: 18ASF2G72PZ-2G6D1 > Size: 16 GB Part Number: 18ASF2G72PZ-2G6D1 > Size: 16 GB Part Number: 18ASF2G72PZ-2G6D1 > Size: 16 GB Part Number: 18ASF2G72PZ-2G6D1 > Size: No Module Installed > Size: No Module Installed > Size: No Module Installed > Size: No Module Installed > > Signed-off-by: Alexander Zeidler > --- > v2: > * make regex stricter > * reduce possible dmidecode output which is not needed here > * reduce and clarify the printed information > > v1: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062348.html > > > PVE/Report.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/PVE/Report.pm b/PVE/Report.pm > index 9d1b9b27..d9f81a0f 100644 > --- a/PVE/Report.pm > +++ b/PVE/Report.pm > @@ -113,6 +113,7 @@ my $init_report_cmds = sub { > 'cd /sys/devices/virtual/dmi/id; grep -HT "" sys_vendor product_name product_version', > 'cd /sys/devices/virtual/dmi/id; grep -HT "" board_vendor board_name board_version', > 'dmidecode -t 0,3,32', > + 'dmidecode -t16,17 | grep -P "^\t(Max[^:]*city|Size|Part)" | sed -Ez "s/\n(\tP[^\n]*)/\1/g" | sort', Please add a space between `-t` and `16,17`. > 'lspci -nnk', > ], > }, To be honest, I'm not a fan of this command. In those few cases it was interesting to see, we often wanted to see all the information. And the full dmidecode -t 17 output is just too much for the report. Not to mention the quite complicated `grep | sed | sort` part that might break on some systems that report things differently. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel