From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 91CED60F98 for ; Wed, 16 Dec 2020 08:21:04 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7D09018DFC for ; Wed, 16 Dec 2020 08:20:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6D20518DEC for ; Wed, 16 Dec 2020 08:20:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3DE5945203 for ; Wed, 16 Dec 2020 08:20:33 +0100 (CET) To: Proxmox VE development discussion , Aaron Lauterer References: <20201215152204.1659-1-a.lauterer@proxmox.com> <20201215152204.1659-2-a.lauterer@proxmox.com> From: Thomas Lamprecht Message-ID: <3e17f5b5-3b2d-0b4b-3479-c07955fbc5c4@proxmox.com> Date: Wed, 16 Dec 2020 08:20:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Thunderbird/84.0 MIME-Version: 1.0 In-Reply-To: <20201215152204.1659-2-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.066 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] ui: improve description of guest-fstrim checkbox X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Dec 2020 07:21:04 -0000 On 15.12.20 16:22, Aaron Lauterer wrote: > The phrasing left some room to speculation when this would actually be > run, e.g. after cloning a full VM? Adding/Expanding a QGA pve-docs section with that info in detail and adding a onlineHelp button here would be also great, allows to explain it in full detail without the need for shorter abbreviated sentences. > > Currently the only instances where it is used is after moving a disk or > migrating a VM. > > Signed-off-by: Aaron Lauterer > --- > www/manager6/form/AgentFeatureSelector.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/manager6/form/AgentFeatureSelector.js b/www/manager6/form/AgentFeatureSelector.js > index 122c8713..6c21306f 100644 > --- a/www/manager6/form/AgentFeatureSelector.js > +++ b/www/manager6/form/AgentFeatureSelector.js > @@ -14,7 +14,7 @@ Ext.define('PVE.form.AgentFeatureSelector', { > }, > { > xtype: 'proxmoxcheckbox', > - boxLabel: gettext('Run guest-trim after clone disk'), > + boxLabel: gettext('Run guest-trim after a disk move or VM migration'), > name: 'fstrim_cloned_disks', > bind: { > disabled: '{!enabled.checked}', >