From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 2AEF01FF161 for ; Tue, 10 Sep 2024 14:25:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 85F5D351D4; Tue, 10 Sep 2024 14:25:17 +0200 (CEST) Message-ID: <3dc06d64-0bbc-45c9-b764-93a163828eff@proxmox.com> Date: Tue, 10 Sep 2024 14:24:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Maximiliano Sandoval References: <20240812114411.155945-1-m.sandoval@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20240812114411.155945-1-m.sandoval@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH storage v3 1/2] fix #5267: storage: add bzip2 support X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 12.08.24 um 13:44 schrieb Maximiliano Sandoval: > A popular ISO compressed exclusively with bz2 is OPNsense [2]. > > Since this requires adding `bz2` to the list of known compression > formats we add decompression methods for vmz a tar. Typo here I presume. > diff --git a/src/test/list_volumes_test.pm b/src/test/list_volumes_test.pm > index d155cb9..ba959ff 100644 > --- a/src/test/list_volumes_test.pm > +++ b/src/test/list_volumes_test.pm > @@ -189,6 +189,7 @@ my @tests = ( > "$storage_dir/dump/vzdump-lxc-16112-2020_03_30-21_49_30.tar.gz", > "$storage_dir/dump/vzdump-lxc-16112-2020_03_30-21_49_30.tar.zst", > "$storage_dir/dump/vzdump-lxc-16112-2020_03_30-21_59_30.tgz", > + "$storage_dir/dump/vzdump-openvz-16112-2020_03_30-21_39_30.tar.bz2", > ], > expected => [ > { > @@ -237,6 +238,15 @@ my @tests = ( > 'vmid' => '16112', > 'volid' => 'local:backup/vzdump-lxc-16112-2020_03_30-21_59_30.tgz', > }, > + { > + 'content' => 'backup', > + 'ctime' => 1585604370, > + 'format' => 'tar.bz2', > + 'size' => DEFAULT_SIZE, > + 'subtype' => 'openvz', > + 'vmid' => '16112', > + 'volid' => 'local:backup/vzdump-openvz-16112-2020_03_30-21_39_30.tar.bz2', > + }, > ], > }, > { > @@ -440,7 +450,6 @@ my @tests = ( > "$storage_dir/template/cache/debian-10.0-standard_10.0-1_amd64.zip.gz", > "$storage_dir/template/cache/debian-10.0-standard_10.0-1_amd64.tar.bz2", Why is this one still listed here in the non-matching test cases? Shouldn't this be recognized too now? > "$storage_dir/private/subvol-19254-disk-0/19254", > - "$storage_dir/dump/vzdump-openvz-16112-2020_03_30-21_39_30.tar.bz2", > "$storage_dir/dump/vzdump-openvz-16112-2020_03_30-21_39_30.zip.gz", > "$storage_dir/dump/vzdump-openvz-16112-2020_03_30-21_39_30.tgz.lzo", > "$storage_dir/dump/vzdump-qemu-16110-2020_03_30-21_12_40.vma.xz", _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel