From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 69A418EAA for ; Wed, 16 Nov 2022 18:41:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 49746237DE for ; Wed, 16 Nov 2022 18:41:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 16 Nov 2022 18:41:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 633DF44D77 for ; Wed, 16 Nov 2022 18:41:43 +0100 (CET) Message-ID: <3d2259aa-7d92-c5e1-9db4-7122eaa30517@proxmox.com> Date: Wed, 16 Nov 2022 18:41:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 Content-Language: en-GB To: Proxmox VE development discussion , Wolfgang Bumiller References: <20221116171408.216775-1-w.bumiller@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221116171408.216775-1-w.bumiller@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: =?UTF-8?Q?0=0A=09?=AWL -0.031 Adjusted score from AWL reputation of From: =?UTF-8?Q?address=0A=09?=BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict =?UTF-8?Q?Alignment=0A=09?=SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF =?UTF-8?Q?Record=0A=09?=SPF_PASS -0.001 SPF: sender matches SPF =?UTF-8?Q?record=0A=09?=URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [cloudinit.pm, qemu.pm, qemuserver.pm] Subject: [pve-devel] applied-series: [PATCH qemu-server 0/6] Manage [special:cloudinit] in hotplug code X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Nov 2022 17:41:44 -0000 Am 16/11/2022 um 18:14 schrieb Wolfgang Bumiller: > The inital series by Alexandre always dumped this section into the > config even if no cloud-init was being used and the api to get the > pending changes performed filtering which should instead be part of the > hotplug code. > > See the individual commit messages. > > This partially reverts some of Thomas' cleanups as - unless I missed > something - image generation and writing of the config only happens in > paths that are already allowed to write it, plus, the hotplug code will > now fully manage the [special:cloudinit] section, including removing > values which have been reverted to the state that was used for the last > cloud-init image generation. > > Wolfgang Bumiller (6): > Revert "cloudinit: avoid unsafe write of VM config" > Partially-revert "cloudinit: add cloudinit section for current > generated config" > delay cloudinit generation in hotplug > record cloud-init changes in the cloudinit section > don't call 'cleanup_config' the cloudinit section > drop get_pending_changes and simplify cloudinit_pending api call > > PVE/API2/Qemu.pm | 44 ++++++------ > PVE/QemuServer.pm | 132 +++++++++++++++++++++++++++++------- > PVE/QemuServer/Cloudinit.pm | 122 ++++++--------------------------- > 3 files changed, 153 insertions(+), 145 deletions(-) > applied series, much thanks!