From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id ABDDA1FF162
for <inbox@lore.proxmox.com>; Mon, 7 Apr 2025 14:04:23 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 011583D47D;
Mon, 7 Apr 2025 14:04:22 +0200 (CEST)
Message-ID: <3c6099b6-8327-48bd-a08a-c63f5030b00f@proxmox.com>
Date: Mon, 7 Apr 2025 14:03:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20250404160847.489922-1-m.frank@proxmox.com>
<20250404160847.489922-5-m.frank@proxmox.com>
<94a431c4-2d55-4974-8463-c2d6aa9616d5@proxmox.com>
<95cf89d5-98b2-485c-82a4-af905d5f516f@proxmox.com>
<8ac83b86-2442-4e5b-b49c-e44801a1a8b4@proxmox.com>
From: Markus Frank <m.frank@proxmox.com>
In-Reply-To: <8ac83b86-2442-4e5b-b49c-e44801a1a8b4@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.001 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH qemu-server v16 4/12] control: add virtiofsd
as runtime dependency for qemu-server
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On 2025-04-07 14:00, Thomas Lamprecht wrote:
> Am 07.04.25 um 12:59 schrieb Markus Frank:
>> On 2025-04-07 12:43, Thomas Lamprecht wrote:
>>> Would your code handle the case where the executable does not exist
>>> with a somewhat nice error?
>> No, it does not.
>>
>> But it can easily be added.
>>
>> diff --git a/PVE/QemuServer/Virtiofs.pm b/PVE/QemuServer/Virtiofs.pm
>> index 5b948d57..6c9018e5 100644
>> --- a/PVE/QemuServer/Virtiofs.pm
>> +++ b/PVE/QemuServer/Virtiofs.pm
>> @@ -163,6 +163,9 @@ sub start_virtiofsd {
>> my $dir_cfg = PVE::Mapping::Dir::find_on_current_node($virtiofs->{dirid});
>>
>> my $virtiofsd_bin = '/usr/libexec/virtiofsd';
>> + if (! -f $virtiofsd_bin) {
>> + print "virtiofsd is not installed. To use virtio-fs, install virtiofsd via apt.\n";
>
> s/print/die/, I'd think? Or at least log_warn + early return.
Yes, should be a die. My mistake.
>
> And could you send a v17 with that changed? Maybe also the
> UI proposal from Filip (please talk with Dominik about if that
> would be fine in general)
Okay, I will do that.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel