From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A1F216A5D7 for ; Wed, 16 Mar 2022 12:04:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 985FE26B24 for ; Wed, 16 Mar 2022 12:04:27 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id AC30526B18 for ; Wed, 16 Mar 2022 12:04:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7E5AD4635E for ; Wed, 16 Mar 2022 12:04:26 +0100 (CET) Message-ID: <3c52b1a7-c53f-27de-f072-f8ddab32e102@proxmox.com> Date: Wed, 16 Mar 2022 12:04:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Content-Language: en-US To: pve-devel@lists.proxmox.com, =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20211216121233.162288-1-f.ebner@proxmox.com> <20211216121233.162288-10-f.ebner@proxmox.com> From: Fabian Ebner In-Reply-To: <20211216121233.162288-10-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.122 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH guest-common 1/1] vzdump: schema: add 'notes' and 'protected' properties X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2022 11:04:27 -0000 Am 16.12.21 um 13:12 schrieb Fabian Ebner: > In command_line(), notes are printed, quoted, but otherwise as is, > which is a bit ugly for multi-line notes. But it is part of the > commandline. > > Signed-off-by: Fabian Ebner > --- > src/PVE/VZDump/Common.pm | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm > index 83d7413..5bb35ec 100644 > --- a/src/PVE/VZDump/Common.pm > +++ b/src/PVE/VZDump/Common.pm > @@ -233,7 +233,19 @@ my $confdesc = { > type => 'string', > description => 'Backup all known guest systems included in the specified pool.', > optional => 1, > - } > + }, > + notes => { > + type => 'string', > + description => "Notes to add to the backup(s).", > + requires => 'storage', > + optional => 1, > + }, Quoting off-list discussion here, where it belongs and so we don't forget about it ;) With regard to fixing https://bugzilla.proxmox.com/show_bug.cgi?id=438 after all those years. Fabian G.: we could offer something like a simple template system that allows substitution of certain variables (like name, or source node hostname/clustername, ..). or just a boolean switch for setting VM/CT $HOSTNAME from $CLUSTER/$NODENAME (or an enum, with [job-comment,hostname,long,none] where long is that, and hostname is just the guest hostname, and job-comment is the comment of the vzdump job if one is set) Me: The template variant would be the most flexible one and would avoid the need for a second vzdump option besides --notes. Ideally, support for it would be there from the beginning though, as otherwise it will stop working for a user wanting to literally set $HOSTNAME when we add it ;) The downside is that it doesn't match the volume-level --notes option, but I don't think that should be a big deal. Fabian G.: well it could just be called notes-template for vzdump to disambiguate? > + protected => { > + type => 'boolean', > + description => "If true, mark backup(s) as protected.", > + requires => 'storage', > + optional => 1, > + }, > }; > > sub get_confdesc {