From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BDB8C74F57 for ; Tue, 12 Oct 2021 10:26:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B8D302937D for ; Tue, 12 Oct 2021 10:26:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 02AD92936F for ; Tue, 12 Oct 2021 10:26:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CE2D645D26 for ; Tue, 12 Oct 2021 10:25:58 +0200 (CEST) To: pve-devel@lists.proxmox.com, Lorenz Stechauner References: <20211011121347.3366696-1-l.stechauner@proxmox.com> From: Fabian Ebner Message-ID: <3c0f26b6-23de-2aab-e353-30998a4e2e38@proxmox.com> Date: Tue, 12 Oct 2021 10:25:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211011121347.3366696-1-l.stechauner@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [glusterfsplugin.pm, plugin.pm, cifsplugin.pm, dirplugin.pm, nfsplugin.pm, btrfsplugin.pm] URI_NOVOWEL 0.5 URI hostname has long non-vowel sequence Subject: Re: [pve-devel] [PATCH-SERIES v3 storage/manager] fix #3580: make preallocation mode selectable for qcow2 and raw images X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Oct 2021 08:26:05 -0000 If a patch and its context doesn't change code-wise, you can add the Reviewed-by and Tested-by tags from the previous version. While testing, I found that the last patch is missing 'glusterfs' in the list of storage types. Except for that: Reviewed-by: Fabian Ebner Tested-by: Fabian Ebner Am 11.10.21 um 14:13 schrieb Lorenz Stechauner: > changes to v2: > * cleaned up commit message for pve-storage > * changed implementation to put the preallocation selector on the column with fewer items > > changes to v1: > * adjusted preallocation api description > * moved sub preallocation_cmd_option above `# Storage implementation` > * updated PreallocationSelector to work with `default` > * reworked placement of Prealloc.Selector in Base.js > > > pve-storage: > Lorenz Stechauner (1): > fix #3580: plugins: make preallocation mode selectable for qcow2 and > raw images > > PVE/Storage/BTRFSPlugin.pm | 1 + > PVE/Storage/CIFSPlugin.pm | 1 + > PVE/Storage/DirPlugin.pm | 1 + > PVE/Storage/GlusterfsPlugin.pm | 4 ++- > PVE/Storage/NFSPlugin.pm | 1 + > PVE/Storage/Plugin.pm | 48 +++++++++++++++++++++++++++++++++- > 6 files changed, 54 insertions(+), 2 deletions(-) > > > pve-manager > Lorenz Stechauner (2): > ui: add PreallocationSelector > fix 3850: ui: storage: using PreallocationSelector for file based > storage types > > www/manager6/Makefile | 1 + > www/manager6/controller/StorageEdit.js | 6 ++++++ > www/manager6/form/PreallocationSelector.js | 11 +++++++++++ > www/manager6/storage/Base.js | 20 ++++++++++++++++++++ > www/manager6/storage/NFSEdit.js | 2 +- > 5 files changed, 39 insertions(+), 1 deletion(-) > create mode 100644 www/manager6/form/PreallocationSelector.js >