From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BFB231FF16F for ; Thu, 30 Jan 2025 13:18:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 035B6108E9; Thu, 30 Jan 2025 13:18:39 +0100 (CET) Message-ID: <3b9e9ecb-08ca-4acc-a829-3f48d357e56f@proxmox.com> Date: Thu, 30 Jan 2025 13:18:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Filip Schauer References: <20250129155339.164696-1-f.schauer@proxmox.com> <20250129155339.164696-9-f.schauer@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20250129155339.164696-9-f.schauer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server v2 8/9] allow non-root users to set /dev/u?random as an RNG source X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 29.01.25 um 16:53 schrieb Filip Schauer: > Allow non-root users with the VM.Config.HWType privilege to configure > /dev/urandom & /dev/random as an entropy source for a VirtIO RNG device. > /dev/hwrng remains restricted to the root user. > > Signed-off-by: Filip Schauer > --- > PVE/API2/Qemu.pm | 42 ++++++++++++++++++++++++++++++++++++++++++ > PVE/QemuServer.pm | 13 +++++++++++-- > 2 files changed, 53 insertions(+), 2 deletions(-) > > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index db356b7e..8262c9d4 100644 > --- a/PVE/API2/Qemu.pm > +++ b/PVE/API2/Qemu.pm > @@ -670,6 +670,7 @@ my $hwtypeoptions = { > 'vga' => 1, > 'watchdog' => 1, > 'audio0' => 1, > + 'rng0' => 1, > }; > > my $generaloptions = { > @@ -798,6 +799,36 @@ my sub check_vm_create_hostpci_perm { > return 1; > }; > > +my sub check_rng_perm { > + my ($rpcenv, $authuser, $vmid, $pool, $opt, $value) = @_; > + > + return 1 if $authuser eq 'root@pam'; > + > + $rpcenv->check_vm_perm($authuser, $vmid, $pool, ['VM.Config.HWType']); > + > + my $device = PVE::JSONSchema::parse_property_string('pve-qm-rng', $value); Nit: missing explicit use statement for the RNG module (that is where the format is registered). _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel