From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B14521FF15E for ; Fri, 20 Sep 2024 16:27:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8CCB037670; Fri, 20 Sep 2024 16:28:04 +0200 (CEST) Message-ID: <3b895bb4-954a-4284-a248-3d22de7bbf8d@proxmox.com> Date: Fri, 20 Sep 2024 16:28:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Daniel Kral To: Proxmox VE development discussion , Filip Schauer References: <20240918144953.130780-1-f.schauer@proxmox.com> <20240918144953.130780-7-f.schauer@proxmox.com> Content-Language: en-US In-Reply-To: <20240918144953.130780-7-f.schauer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v4 storage 6/6] pvesm: add a move-volume command X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 9/18/24 16:49, Filip Schauer wrote: > The method can be called from the PVE shell with `pvesm move-volume`: > > ``` > pvesm move-volume [--target-node ] [--delete] > ``` > > For example to move a VMA backup to a Proxmox Backup Server: > > ``` > pvesm move-volume \ > local:backup/vzdump-qemu-100-2024_06_25-13_08_56.vma.zst pbs > ``` > > Or move a container template to another node and delete the source: > > ``` > pvesm move-volume \ > local:vztmpl/devuan-4.0-standard_4.0_amd64.tar.gz local \ > --target-node pvenode2 --delete > ``` > > Signed-off-by: Filip Schauer > --- > src/PVE/CLI/pvesm.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/PVE/CLI/pvesm.pm b/src/PVE/CLI/pvesm.pm > index 9b9676b..8031fc1 100755 > --- a/src/PVE/CLI/pvesm.pm > +++ b/src/PVE/CLI/pvesm.pm > @@ -690,6 +690,8 @@ our $cmddef = { > print "APIVER $res->{apiver}\n"; > print "APIAGE $res->{apiage}\n"; > }], > + 'move-volume' => [ "PVE::API2::Storage::Content", 'move', ['volume', 'target-storage'], > + { node => $nodename } ], > 'prune-backups' => [ __PACKAGE__, 'prunebackups', ['storage'], { node => $nodename }, sub { > my $res = shift; > nit: In my opinion, this patch could be moved up at least where the 'move-volume' API method was introduced, so that the 'move-volume' can be invoked in whatever 'style' people like, but this is something more minor. Nevertheless, the CLI utility works just like the curl/pvesh API call as far as I can tell by testing this with the test cases I have pointed out in the previous patches. Reviewed-by: Daniel Kral Tested-by: Daniel Kral _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel