From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 1EC011FF0B0 for ; Tue, 27 Oct 2026 11:13:34 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id BF09A21621; Tue, 27 Oct 2026 11:13:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=genua.de; s=202307; t=1793095938; bh=zXs7sBkh3cP7zupDgKwP973d6ckRRvJs3ufLOICveAs=; h=Date:From:To:Subject:References:In-Reply-To:From; b=b0gvS+WhU+R4Xa6yzCUzesqx+hx+b550Hyp+Qr4pGA0snhEEYF6hCACIrVR3kvD0G yOrOg8y3hl0Uh2qwAGWBRT+zDeoEmzv2foBg+2Xu8fNGzjxq829O3CVktsrUWa8JNx oYLdYiwPZy8kjPwnP/jatPBk54rGXbdhaDS9entxNE2cHkb3TUQaSyy6FAaZSWUntd fZIFWH/oyOGDl76TBLx249G1a4D8k7PHiKN89J5eO24vK45NqX47AsGIPYJ/oPIK7G ANBwS7aROPbveoQ7yMigAMwIqLvwlCE2wkEgnSTsjaEDD36ZDQ/j8PTibjUmbUQ0Gh 5NVJ373CvzVuQ== Date: Tue, 27 Oct 2026 11:12:17 +0100 From: Christian Ludwig To: Subject: [PATCH pve-storage v3 07/19] test: list volumes: cover efi-firmware volumes Message-ID: <3b322d7d51747f0ec76a3bbbae1e024ddd163067.1793029144.git@genua.de> References: MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [192.168.217.185] X-ClientProxiedBy: kch1-mta09.win.genua.de (10.208.16.109) To kch1-mta07.win.genua.de (10.208.16.107) Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-SPAM-LEVEL: Spam detection results: 0 AWL 0.069 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record UNPARSEABLE_RELAY 0.001 Informational: message has unparseable relay lines Message-ID-Hash: O5FDNRGMMA2B6ZKREODKQ6LVDLJA2DYL X-Message-ID-Hash: O5FDNRGMMA2B6ZKREODKQ6LVDLJA2DYL X-MailFrom: christian_ludwig@genua.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Check that files in efi-firmware/ are listed as efi-firmware volumes, and that only files ending in '.fd' are considered. Signed-off-by: Christian Ludwig --- src/test/list_volumes_test.pm | 47 ++++++++++++++++++++++++++++++++++- 1 file changed, 46 insertions(+), 1 deletion(-) diff --git a/src/test/list_volumes_test.pm b/src/test/list_volumes_test.pm index 0876902..4a1ac45 100644 --- a/src/test/list_volumes_test.pm +++ b/src/test/list_volumes_test.pm @@ -72,6 +72,7 @@ my $scfg = { 'images' => 1, 'snippets' => 1, 'backup' => 1, + 'efi-firmware' => 1, }, }; @@ -462,6 +463,50 @@ my @tests = ( ], expected => [], # returns empty list }, + { + description => 'VMID: none, efi-firmware .fd files listed', + vmid => undef, + files => [ + "$storage_dir/efi-firmware/custom.fd", + "$storage_dir/efi-firmware/vendor-bios-v2.fd", + ], + expected => [ + { + 'content' => 'efi-firmware', + 'ctime' => DEFAULT_CTIME, + 'format' => 'raw', + 'size' => DEFAULT_SIZE, + 'volid' => 'local:efi-firmware/custom.fd', + }, + { + 'content' => 'efi-firmware', + 'ctime' => DEFAULT_CTIME, + 'format' => 'raw', + 'size' => DEFAULT_SIZE, + 'volid' => 'local:efi-firmware/vendor-bios-v2.fd', + }, + ], + }, + { + description => 'VMID: none, only efi-firmware files ending in .fd listed', + vmid => undef, + files => [ + "$storage_dir/efi-firmware/custom.fd", + "$storage_dir/efi-firmware/custom.FD", + "$storage_dir/efi-firmware/custom.iso", + "$storage_dir/efi-firmware/custom.raw", + "$storage_dir/efi-firmware/custom", + ], + expected => [ + { + 'content' => 'efi-firmware', + 'ctime' => DEFAULT_CTIME, + 'format' => 'raw', + 'size' => DEFAULT_SIZE, + 'volid' => 'local:efi-firmware/custom.fd', + }, + ], + }, ); # provide static vmlist for tests @@ -520,7 +565,7 @@ plan tests => $plan + 1; { my $sid = 'local'; - my $types = ['rootdir', 'images', 'vztmpl', 'iso', 'backup', 'snippets']; + my $types = ['rootdir', 'images', 'vztmpl', 'iso', 'backup', 'snippets', 'efi-firmware']; my @suffixes = ('qcow2', 'raw', 'vmdk', 'vhdx'); # run through test cases -- 2.34.1