From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8D5041FF13B for ; Wed, 25 Mar 2026 13:17:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 69D2D16C9C; Wed, 25 Mar 2026 13:17:59 +0100 (CET) Message-ID: <3a192d9c-eb4d-4a09-9faa-f50c2c24fd9d@proxmox.com> Date: Wed, 25 Mar 2026 13:17:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox v2 1/8] serde: implement ini serializer To: Christoph Heiss References: <20260213143601.1424613-1-c.heiss@proxmox.com> <20260213143601.1424613-2-c.heiss@proxmox.com> <867329b9-bebe-4c6d-8d0e-3f33e220c235@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774440998165 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 4W345RJ2ZJ4JFJSJOMPKWKQB4H7NMKPC X-Message-ID-Hash: 4W345RJ2ZJ4JFJSJOMPKWKQB4H7NMKPC X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Wolfgang Bumiller , pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 25.03.26 um 12:40 schrieb Christoph Heiss: >> Any technical reason for this to be in proxmox-serde over a dedicated >> crate? like proxmox-ini or proxmox-ini-config or the like? > Not really. Didn't know if we wanted a dedicated crate for this and - as > you say below - proxmox-serde is mixed bag of serde-related stuff and > it kind of fitted, so just decided to put it there for now. > > Will move it to a separate crate for v3. Alternative could be to just put it in proxmox-wireguard directly for now. But that mostly depends on how specific this INI flavor is, or how different the ones for potential use cases (besides this the usage in systemd and git might be the most prominent ones that might interest us already or sooner or later).