From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CC99A91ACD for ; Thu, 4 Apr 2024 16:23:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B7CA53295 for ; Thu, 4 Apr 2024 16:23:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 4 Apr 2024 16:23:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7509C42661 for ; Thu, 4 Apr 2024 16:23:49 +0200 (CEST) Message-ID: <394c6d86-e713-4d77-8f88-31bf4c15ce5d@proxmox.com> Date: Thu, 4 Apr 2024 16:23:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pve-devel@lists.proxmox.com References: <20240402110740.291710-3-s.lendl@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <20240402110740.291710-3-s.lendl@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.579 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v3 pve-network 0/5] SDN: Add mocking to run tests in sbuild X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Apr 2024 14:23:50 -0000 Tested building this with sbuild - completed successfully (including tests). I've also checked out the changes and tested them by creating a new EVPN zone and setting a local frr config. Everything still seems to be working as before. Consider this: Tested-By: Stefan Hanreich On 4/2/24 13:07, Stefan Lendl wrote: > Extract and mock functions that otherwise access system files which is not > possible in a clean sbuild environment. > Namely /etc/network/interfaces as well as /etc/frr/frr.config.local > Added .gitignore for sbuild artifacts > > Changes v2 -> v3: > * Changed commit messages according to commit guide lines > * Not importing Dumper in zones test > * Re-Enabled DNS tests > * Added .gitignore which was previously a separate patch > > Changes v1 -> v2: > * Disabled DNS tests because they fail > > > Stefan Lendl (5): > controllers: extract read_etc_network_interfaces > evpn: extract read_local_frr_config > tests: mocking more functions to avoid system access > tests: run tests in sbuild > gitignore: build artifacts from sbuild > > .gitignore | 3 ++ > src/Makefile | 2 +- > src/PVE/Network/SDN/Controllers.pm | 16 +++++++--- > src/PVE/Network/SDN/Controllers/EvpnPlugin.pm | 10 ++++-- > src/test/run_test_zones.pl | 31 +++++++++++++++++++ > 5 files changed, 54 insertions(+), 8 deletions(-) >