From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 384396B02A
 for <pve-devel@lists.proxmox.com>; Thu, 10 Dec 2020 11:33:26 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 252AE19B02
 for <pve-devel@lists.proxmox.com>; Thu, 10 Dec 2020 11:32:56 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 1445919AF6
 for <pve-devel@lists.proxmox.com>; Thu, 10 Dec 2020 11:32:55 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CC95344687
 for <pve-devel@lists.proxmox.com>; Thu, 10 Dec 2020 11:32:54 +0100 (CET)
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Aaron Lauterer <a.lauterer@proxmox.com>
References: <20201120132753.20966-1-a.lauterer@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Message-ID: <3934e35d-14ad-7709-2fff-9c5d48cf1896@proxmox.com>
Date: Thu, 10 Dec 2020 11:32:54 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101
 Thunderbird/84.0
MIME-Version: 1.0
In-Reply-To: <20201120132753.20966-1-a.lauterer@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.069 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend v2 0/3] Add first
 welcome screen
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 10 Dec 2020 10:33:26 -0000

On 20.11.20 14:27, Aaron Lauterer wrote:
> This patch series introduces a "first welcome screen" shown on first
> start.
>=20
> Additionally, a class that stores the proxmox corporate identity (CI)
> colors is introduced.
>=20
> Changes to v1:
> * rework welcome screens, mainly use buttons instead of text links
> * cleanup code
> * use async where needed
> * fix image sizes for added logo
>=20
> Aaron Lauterer (3):
>   add class for Proxmox corporate identity colors
>   add Proxmox symbol logo white orange
>   Add first welcome screen
>=20

Can you re-check the layout also a bit when running it as desktop applica=
tion?
Not a complete deal breaker but would be nice to get that layout a bit mo=
re fitting
there too:

# flutter run -d linux

Besides that, for the actual use case it looks quite nice, great work!
Would like to still take a closer look at the code.