From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A8D89BF267 for ; Thu, 4 Jan 2024 14:02:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 81D58F052 for ; Thu, 4 Jan 2024 14:01:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 4 Jan 2024 14:01:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C03DB46219 for ; Thu, 4 Jan 2024 14:01:38 +0100 (CET) Message-ID: <39280e58-8b01-4007-b5ff-9ac39a76e247@proxmox.com> Date: Thu, 4 Jan 2024 14:01:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Fiona Ebner , Proxmox VE development discussion References: <20231212085042.51082-1-l.wagner@proxmox.com> <8d9113ea-863e-476b-93cf-4c9e87d527fb@proxmox.com> Content-Language: de-AT, en-US From: Lukas Wagner In-Reply-To: <8d9113ea-863e-476b-93cf-4c9e87d527fb@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH widget-toolkit v2] notify: sendmail: smtp: fix mailto/mailto-user parameter deletion X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jan 2024 13:02:10 -0000 On 1/4/24 13:41, Fiona Ebner wrote: > > Worked for me too :) > > However, I noticed that there were already cbinds for deleteEmpty for > the mailto/mailto-user fields and wondered why that didn't have an > effect. Turns out, it's because they're nested in another widget and > that requires an additional cbind. > > Alternative patch with that approach sent here: > https://lists.proxmox.com/pipermail/pve-devel/2024-January/061217.html I think your approach is the better solution for this problem, my patch can be ignored. -- - Lukas