From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 081621FF141 for ; Tue, 30 Jun 2026 11:49:19 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E66F221418; Tue, 30 Jun 2026 11:49:17 +0200 (CEST) Message-ID: <3918ef95-3b3b-48ec-825e-c61470eb3549@proxmox.com> Date: Tue, 30 Jun 2026 11:49:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH-SERIES qemu-server 0/3] fix #7743: api: disk import: avoid locking twice when importing from OVA or same VM To: pve-devel@lists.proxmox.com References: <20260629124625.115457-1-f.ebner@proxmox.com> Content-Language: en-US From: Manuel Federanko In-Reply-To: <20260629124625.115457-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782812940390 X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VUJ6MDJOYMI3T2K6J4KF4HC4LQ7LZTLU X-Message-ID-Hash: VUJ6MDJOYMI3T2K6J4KF4HC4LQ7LZTLU X-MailFrom: m.federanko@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi, I built the package, installed it and check that the issue no longer exists with my reproducer [0]. Everything seems to be working fine. Thanks! Tested-by: Manuel Federanko [0] https://bugzilla.proxmox.com/show_bug.cgi?id=7743 On 2026-06-29 2:46 PM, Fiona Ebner wrote: > When import_from_volid->() is called, the VM configuration of the > destination VM is already locked. In case the source volume belongs to > the same VM, there would be a second attempt to lock the config. In > particular, this also happens when importing from OVA, because the > source image is first extracted and belongs to the same VM. > > Additionally, the update VM API call is changed to fork before > locking using the usual early+repeated checks pattern. > > qemu-server: > > Fiona Ebner (3): > api: disk import: remove unused wrongly named variable > fix #7743: api: disk import: avoid locking twice when importing from > OVA or same VM > api: update vm: fork before locking > > src/PVE/API2/Qemu.pm | 780 ++++++++++++++++++++++--------------------- > 1 file changed, 397 insertions(+), 383 deletions(-) > > > Summary over all repositories: > 1 files changed, 397 insertions(+), 383 deletions(-) >