From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9BE129F35D for ; Wed, 7 Jun 2023 19:40:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 805621DD5A for ; Wed, 7 Jun 2023 19:39:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 7 Jun 2023 19:39:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9500341FBA for ; Wed, 7 Jun 2023 19:39:56 +0200 (CEST) Message-ID: <38fd082c-7af5-2552-fc50-77e41611b57f@proxmox.com> Date: Wed, 7 Jun 2023 19:39:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB, de-AT To: Proxmox VE development discussion , Fiona Ebner References: <20230524135654.214008-1-f.ebner@proxmox.com> From: Thomas Lamprecht Autocrypt: addr=t.lamprecht@proxmox.com; keydata= xsFNBFsLjcYBEACsaQP6uTtw/xHTUCKF4VD4/Wfg7gGn47+OfCKJQAD+Oyb3HSBkjclopC5J uXsB1vVOfqVYE6PO8FlD2L5nxgT3SWkc6Ka634G/yGDU3ZC3C/7NcDVKhSBI5E0ww4Qj8s9w OQRloemb5LOBkJNEUshkWRTHHOmk6QqFB/qBPW2COpAx6oyxVUvBCgm/1S0dAZ9gfkvpqFSD 90B5j3bL6i9FIv3YGUCgz6Ue3f7u+HsEAew6TMtlt90XV3vT4M2IOuECG/pXwTy7NtmHaBQ7 UJBcwSOpDEweNob50+9B4KbnVn1ydx+K6UnEcGDvUWBkREccvuExvupYYYQ5dIhRFf3fkS4+ wMlyAFh8PQUgauod+vqs45FJaSgTqIALSBsEHKEs6IoTXtnnpbhu3p6XBin4hunwoBFiyYt6 YHLAM1yLfCyX510DFzX/Ze2hLqatqzY5Wa7NIXqYYelz7tXiuCLHP84+sV6JtEkeSUCuOiUY virj6nT/nJK8m0BzdR6FgGtNxp7RVXFRz/+mwijJVLpFsyG1i0Hmv2zTn3h2nyGK/I6yhFNt dX69y5hbo6LAsRjLUvZeHXpTU4TrpN/WiCjJblbj5um5eEr4yhcwhVmG102puTtuCECsDucZ jpKpUqzXlpLbzG/dp9dXFH3MivvfuaHrg3MtjXY1i+/Oxyp5iwARAQABzTNUaG9tYXMgTGFt cHJlY2h0IChBdXRoLTQpIDx0LmxhbXByZWNodEBwcm94bW94LmNvbT7CwY4EEwEIADgWIQQO R4qbEl/pah9K6VrTZCM6gDZWBgUCWwuNxgIbAwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAK CRDTZCM6gDZWBm/jD/4+6JB2s67eaqoP6x9VGaXNGJPCscwzLuxDTCG90G9FYu29VcXtubH/ bPwsyBbNUQpqTm/s4XboU2qpS5ykCuTjqavrcP33tdkYfGcItj2xMipJ1i3TWvpikQVsX42R G64wovLs/dvpTYphRZkg5DwhgTmy3mRkmofFCTa+//MOcNOORltemp984tWjpR3bUJETNWpF sKGZHa3N4kCNxb7A+VMsJZ/1gN3jbQbQG7GkJtnHlWkw9rKCYqBtWrnrHa4UAvSa9M/XCIAB FThFGqZI1ojdVlv5gd6b/nWxfOPrLlSxbUo5FZ1i/ycj7/24nznW1V4ykG9iUld4uYUY86bB UGSjew1KYp9FmvKiwEoB+zxNnuEQfS7/Bj1X9nxizgweiHIyFsRqgogTvLh403QMSGNSoArk tqkorf1U+VhEncIn4H3KksJF0njZKfilrieOO7Vuot1xKr9QnYrZzJ7m7ZxJ/JfKGaRHXkE1 feMmrvZD1AtdUATZkoeQtTOpMu4r6IQRfSdwm/CkppZXfDe50DJxAMDWwfK2rr2bVkNg/yZI tKLBS0YgRTIynkvv0h8d9dIjiicw3RMeYXyqOnSWVva2r+tl+JBaenr8YTQw0zARrhC0mttu cIZGnVEvQuDwib57QLqMjQaC1gazKHvhA15H5MNxUhwm229UmdH3KM7BTQRbC43GARAAyTkR D6KRJ9Xa2fVMh+6f186q0M3ni+5tsaVhUiykxjsPgkuWXWW9MbLpYXkzX6h/RIEKlo2BGA95 QwG5+Ya2Bo3g7FGJHAkXY6loq7DgMp5/TVQ8phsSv3WxPTJLCBq6vNBamp5hda4cfXFUymsy HsJy4dtgkrPQ/bnsdFDCRUuhJHopnAzKHN8APXpKU6xV5e3GE4LwFsDhNHfH/m9+2yO/trcD txSFpyftbK2gaMERHgA8SKkzRhiwRTt9w5idOfpJVkYRsgvuSGZ0pcD4kLCOIFrer5xXudk6 NgJc36XkFRMnwqrL/bB4k6Pi2u5leyqcXSLyBgeHsZJxg6Lcr2LZ35+8RQGPOw9C0ItmRjtY ZpGKPlSxjxA1WHT2YlF9CEt3nx7c4C3thHHtqBra6BGPyW8rvtq4zRqZRLPmZ0kt/kiMPhTM 8wZAlObbATVrUMcZ/uNjRv2vU9O5aTAD9E5r1B0dlqKgxyoImUWB0JgpILADaT3VybDd3C8X s6Jt8MytUP+1cEWt9VKo4vY4Jh5vwrJUDLJvzpN+TsYCZPNVj18+jf9uGRaoK6W++DdMAr5l gQiwsNgf9372dbMI7pt2gnT5/YdG+ZHnIIlXC6OUonA1Ro/Itg90Q7iQySnKKkqqnWVc+qO9 GJbzcGykxD6EQtCSlurt3/5IXTA7t6sAEQEAAcLBdgQYAQgAIBYhBA5HipsSX+lqH0rpWtNk IzqANlYGBQJbC43GAhsMAAoJENNkIzqANlYGD1sP/ikKgHgcspEKqDED9gQrTBvipH85si0j /Jwu/tBtnYjLgKLh2cjv1JkgYYjb3DyZa1pLsIv6rGnPX9bH9IN03nqirC/Q1Y1lnbNTynPk IflgvsJjoTNZjgu1wUdQlBgL/JhUp1sIYID11jZphgzfDgp/E6ve/8xE2HMAnf4zAfJaKgD0 F+fL1DlcdYUditAiYEuN40Ns/abKs8I1MYx7Yglu3RzJfBzV4t86DAR+OvuF9v188WrFwXCS RSf4DmJ8tntyNej+DVGUnmKHupLQJO7uqCKB/1HLlMKc5G3GLoGqJliHjUHUAXNzinlpE2Vj C78pxpwxRNg2ilE3AhPoAXrY5qED5PLE9sLnmQ9AzRcMMJUXjTNEDxEYbF55SdGBHHOAcZtA kEQKub86e+GHA+Z8oXQSGeSGOkqHi7zfgW1UexddTvaRwE6AyZ6FxTApm8wq8NT2cryWPWTF BDSGB3ujWHMM8ERRYJPcBSjTvt0GcEqnd+OSGgxTkGOdufn51oz82zfpVo1t+J/FNz6MRMcg 8nEC+uKvgzH1nujxJ5pRCBOquFZaGn/p71Yr0oVitkttLKblFsqwa+10Lt6HBxm+2+VLp4Ja 0WZNncZciz3V3cuArpan/ZhhyiWYV5FD0pOXPCJIx7WS9PTtxiv0AOS4ScWEUmBxyhFeOpYa DrEx In-Reply-To: <20230524135654.214008-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.082 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] partially-applied-series: [PATCH-SERIES v2 qemu-server/qemu] Some breaking QEMU changes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jun 2023 17:40:27 -0000 Am 24/05/2023 um 15:56 schrieb Fiona Ebner: > First one is dropping the custom get_link_status QMP command which I > could not find any users for. > > Second one is dropping left-over, custom, deprecated QMP commands for > drive snapshotting. > > Third one is dropping the dummy id CLI parameter, where the only > remaining user I found is qmeventd, which is adapted to parse the VM > ID from the cgroup proc file instead. > > With the third change, new pve-qemu-kvm will break old qemu-server, > requiring a versioned breaks. > > > Changes in v2: > * also drop deprecated drive snapshot QMP commands > > > qemu-server: > > Fiona Ebner (3): > remove left-over mentions of to-be-dropped, outdated QMP commands > qmeventd: extract vmid from cgroup file instead of cmdline applied, above two > cfg2cmd: drop custom id parameter > > PVE/QMPClient.pm | 4 +- > PVE/QemuServer.pm | 2 - > qmeventd/qmeventd.c | 50 +++++++++++-------- > test/cfg2cmd/bootorder-empty.conf.cmd | 1 - > test/cfg2cmd/bootorder-legacy.conf.cmd | 1 - > test/cfg2cmd/bootorder.conf.cmd | 1 - > ...putype-icelake-client-deprecation.conf.cmd | 1 - > .../custom-cpu-model-defaults.conf.cmd | 1 - > .../custom-cpu-model-host-phys-bits.conf.cmd | 1 - > test/cfg2cmd/custom-cpu-model.conf.cmd | 1 - > test/cfg2cmd/efi-raw-old.conf.cmd | 1 - > test/cfg2cmd/efi-raw-template.conf.cmd | 1 - > test/cfg2cmd/efi-raw.conf.cmd | 1 - > test/cfg2cmd/efi-secboot-and-tpm-q35.conf.cmd | 1 - > test/cfg2cmd/efi-secboot-and-tpm.conf.cmd | 1 - > test/cfg2cmd/efidisk-on-rbd.conf.cmd | 1 - > test/cfg2cmd/i440fx-win10-hostpci.conf.cmd | 1 - > .../cfg2cmd/memory-hotplug-hugepages.conf.cmd | 1 - > test/cfg2cmd/memory-hotplug.conf.cmd | 1 - > test/cfg2cmd/memory-hugepages-1g.conf.cmd | 1 - > test/cfg2cmd/memory-hugepages-2m.conf.cmd | 1 - > test/cfg2cmd/minimal-defaults.conf.cmd | 1 - > test/cfg2cmd/netdev-7.0-multiqueues.conf.cmd | 1 - > test/cfg2cmd/netdev-7.1-multiqueues.conf.cmd | 1 - > test/cfg2cmd/netdev-7.1.conf.cmd | 1 - > test/cfg2cmd/netdev.conf.cmd | 1 - > test/cfg2cmd/pinned-version-pxe-pve.conf.cmd | 1 - > test/cfg2cmd/pinned-version-pxe.conf.cmd | 1 - > test/cfg2cmd/pinned-version.conf.cmd | 1 - > .../q35-linux-hostpci-multifunction.conf.cmd | 1 - > ...q35-linux-hostpci-x-pci-overrides.conf.cmd | 1 - > test/cfg2cmd/q35-linux-hostpci.conf.cmd | 1 - > test/cfg2cmd/q35-simple-6.0.conf.cmd | 1 - > test/cfg2cmd/q35-simple-7.0.conf.cmd | 1 - > test/cfg2cmd/q35-simple-pinned-6.1.conf.cmd | 1 - > test/cfg2cmd/q35-simple.conf.cmd | 1 - > test/cfg2cmd/q35-usb2.conf.cmd | 1 - > test/cfg2cmd/q35-usb3.conf.cmd | 1 - > test/cfg2cmd/q35-win10-hostpci.conf.cmd | 1 - > test/cfg2cmd/qemu-xhci-7.1.conf.cmd | 1 - > test/cfg2cmd/qemu-xhci-q35-7.1.conf.cmd | 1 - > test/cfg2cmd/seabios_serial.conf.cmd | 1 - > ...imple-balloon-free-page-reporting.conf.cmd | 1 - > test/cfg2cmd/simple-btrfs.conf.cmd | 1 - > test/cfg2cmd/simple-virtio-blk.conf.cmd | 1 - > test/cfg2cmd/simple1-template.conf.cmd | 1 - > test/cfg2cmd/simple1.conf.cmd | 1 - > test/cfg2cmd/spice-enhancments.conf.cmd | 1 - > test/cfg2cmd/spice-linux-4.1.conf.cmd | 1 - > test/cfg2cmd/spice-usb3.conf.cmd | 1 - > test/cfg2cmd/spice-win.conf.cmd | 1 - > test/snapshot-test.pm | 3 -- > 52 files changed, 31 insertions(+), 76 deletions(-) > > > qemu: > > Fiona Ebner (3): > drop patch for custom get_link_status QMP command > drop deprecated custom drive snapshot QMP commands applied, above two > drop patch for custom dummy id CLI argument > The id thing is just to small and we might not be the only users, for now let's keep it if it makes problems this major release we can get it to the chopping block with actual reasons then.