From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id 40EBB1FF142
	for <inbox@lore.proxmox.com>; Fri, 03 Jul 2026 11:33:29 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 12BE0213BF;
	Fri, 03 Jul 2026 11:33:29 +0200 (CEST)
Message-ID: <38db2b2e-1fe1-43c6-8f75-d8deb28e60f8@proxmox.com>
Date: Fri, 3 Jul 2026 11:32:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH qemu-server 1/3] api: disk import: remove unused wrongly
 named variable
To: Fiona Ebner <f.ebner@proxmox.com>, pve-devel@lists.proxmox.com
References: <20260629124625.115457-1-f.ebner@proxmox.com>
 <20260629124625.115457-2-f.ebner@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20260629124625.115457-2-f.ebner@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1783071166989
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.062 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: KOJZ7OGMFR4WAQ23VN5FR4DHTSOPGOIZ
X-Message-ID-Hash: KOJZ7OGMFR4WAQ23VN5FR4DHTSOPGOIZ
X-MailFrom: d.csapak@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>

On 6/29/26 2:46 PM, Fiona Ebner wrote:
> The result from parse_volume_id() is the storage ID and the volume
> name. Its input is the volume ID.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>   src/PVE/API2/Qemu.pm | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
> index 9023c344..e575d36b 100644
> --- a/src/PVE/API2/Qemu.pm
> +++ b/src/PVE/API2/Qemu.pm
> @@ -499,7 +499,7 @@ my sub create_disks : prototype($$$$$$$$$$$) {
>   
>                   $needs_creation = $live_import;
>   
> -                my ($source_storage, $source_volid) = PVE::Storage::parse_volume_id($source, 1);
> +                my ($source_storage) = PVE::Storage::parse_volume_id($source, 1);
>   
>                   if ($source_storage) { # PVE-managed volume
>                       my ($vtype, $source_format) =