From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 59DC36A0B4 for ; Wed, 3 Mar 2021 17:53:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 50F51AB54 for ; Wed, 3 Mar 2021 17:53:31 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 36290AB45 for ; Wed, 3 Mar 2021 17:53:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0001F45842 for ; Wed, 3 Mar 2021 17:53:29 +0100 (CET) Message-ID: <38c2b48c-241a-67e6-c88e-7fe69a0cd7d7@proxmox.com> Date: Wed, 3 Mar 2021 17:53:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:87.0) Gecko/20100101 Thunderbird/87.0 Content-Language: en-US To: Proxmox VE development discussion , Fabian Ebner References: <20210303110128.9244-1-f.ebner@proxmox.com> <20210303110128.9244-2-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210303110128.9244-2-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.053 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: Re: [pve-devel] [PATCH qemu-server 1/4] vmstatus: make boolean value explicit X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Mar 2021 16:53:31 -0000 On 03.03.21 12:01, Fabian Ebner wrote: > as otherwise the empty string is printed with 'qm status --verbose' when > it's not a template. > > Signed-off-by: Fabian Ebner > --- > PVE/QemuServer.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index a498444..43d7c6b 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -2621,7 +2621,7 @@ sub vmstatus { > $d->{diskread} = 0; > $d->{diskwrite} = 0; > > - $d->{template} = PVE::QemuConfig->is_template($conf); > + $d->{template} = PVE::QemuConfig->is_template($conf) ? 1 : 0; Any reason to not do: $d->{template} = 1 if PVE::QemuConfig->is_template($conf); (no hard feelings, but this is relatively common pattern for such things, especially if they can be normally more often omitted than not, templates are normally rather outnumbered by non-templates) > > $d->{serial} = 1 if conf_has_serial($conf); > $d->{lock} = $conf->{lock} if $conf->{lock}; >