From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7B6B294C5 for ; Wed, 8 Mar 2023 17:38:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C8BF89599 for ; Wed, 8 Mar 2023 17:38:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 8 Mar 2023 17:38:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6DF6745DF1 for ; Wed, 8 Mar 2023 17:38:25 +0100 (CET) Message-ID: <380337b9-49aa-7fb6-3e29-8f751f6aa2be@proxmox.com> Date: Wed, 8 Mar 2023 17:38:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: Thomas Lamprecht , Proxmox VE development discussion References: <20230308120919.1646218-1-a.lauterer@proxmox.com> <82701573-4e32-550a-7842-d7b2b815754f@proxmox.com> Content-Language: en-US From: Aaron Lauterer In-Reply-To: <82701573-4e32-550a-7842-d7b2b815754f@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.042 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v3 manager 0/2] ui: ceph: improve discoverability of warning details X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2023 16:38:27 -0000 On 3/8/23 17:05, Thomas Lamprecht wrote: > Am 08/03/2023 um 13:09 schrieb Aaron Lauterer: >> The goal for this small series is to make it easier/more obvious to see >> that there are potentially more details for a warning ceph is showing >> by: >> * having a tooltip with the details (limited in length) >> * making the detail/info button more visible >> > > One bug I see is that if I open the detail window, the next extjs (probably store) > refresh seemingly refocuses the some part of the row and then the tooltip pops up > too for the element I'm already having the full detail window open. Thanks for catching that! :-/ > > That said, why not avoid the tooltip but inline the info by moving the severity to > the right, dropping the info button completely and making the grid row expandable, > i.e., like the PMG tracking center grid does? We thought about it, but initially I wasn't too happy about it, because if the detailed error message has many lines and/or long lines, it would be nicer to just open the window and making it as large as possible. With the expandable row, the visible area can be rather small. But with that unfortunate behavior with the detail window opened, I am more inclined to make the rows expandable. I'll give it a try and will send a v4 :) > > Would feel more integrated and less duplicate (tooltip + detail window) > information.