From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4E0D4804ED for ; Wed, 17 Nov 2021 17:27:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 43F81101ED for ; Wed, 17 Nov 2021 17:27:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7137C101E0 for ; Wed, 17 Nov 2021 17:27:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4699343D9A; Wed, 17 Nov 2021 17:27:06 +0100 (CET) Message-ID: <37e5ab74-119b-8839-3da8-2fd9eb72f580@proxmox.com> Date: Wed, 17 Nov 2021 17:27:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:95.0) Gecko/20100101 Thunderbird/95.0 Content-Language: en-US To: Proxmox VE development discussion , =?UTF-8?Q?Jens_Mei=c3=9fner?= References: <20211117080301.50468-1-meissner@b1-systems.de> From: Thomas Lamprecht In-Reply-To: <20211117080301.50468-1-meissner@b1-systems.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.835 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.446 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, acme.sh] Subject: Re: [pve-devel] [PATCH] Add DNS challenge schema for knot. X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Nov 2021 16:27:08 -0000 looks OK in general, one question inline... On 17.11.21 09:03, Jens Mei=C3=9Fner wrote: > Signed-off-by: Jens Mei=C3=9Fner > --- > src/dns-challenge-schema.json | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) >=20 > diff --git a/src/dns-challenge-schema.json b/src/dns-challenge-schema.j= son > index a3a3ebc..d194701 100644 > --- a/src/dns-challenge-schema.json > +++ b/src/dns-challenge-schema.json > @@ -211,7 +211,24 @@ > }, > "kas" : {}, > "kinghost" : {}, > - "knot" : {}, > + "knot" : { > + "fields" : { > + "KNOT_SERVER" : { > + "description" : "Hostname of the RFC 2136 compatible names= erver", > + "type" : "string" > + }, > + "KNOT_KEY" : { > + "description" : "TSIG key (format alg:name:key)", > + "type" : "string" > + }, > + "KNOT_ZONE" : { I did not find this variable being used anywhere in the acme.sh knot plug= in[0], there's only KNOT_SERVER and KNOT_KEY being accessed, so what's up with that one?= [1] https://git.proxmox.com/?p=3Dmirror_acme.sh.git;a=3Dblob;f=3Ddnsapi/d= ns_knot.sh;hb=3D3.0.1 > + "description" : "DNS zone name (optional)", > + "optional" : 1, > + "type" : "string" > + } > + }, > + "name" : "Knot / knsupdate (RFC 2136)" > + }, > "leaseweb" : {}, > "lexicon" : {}, > "linode" : {}, >=20