From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9C15AB8D4E for ; Wed, 6 Dec 2023 15:27:01 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 76C8230EE for ; Wed, 6 Dec 2023 15:26:31 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 6 Dec 2023 15:26:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B48AA42664 for ; Wed, 6 Dec 2023 15:26:30 +0100 (CET) Message-ID: <37d755e3-83ee-4a10-9e94-7f85a56e527b@proxmox.com> Date: Wed, 6 Dec 2023 15:26:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Maximiliano Sandoval Cc: Proxmox VE development discussion References: <20231129132117.217210-1-m.sandoval@proxmox.com> <50f3e171-c2b4-4e59-bd7f-07f81b11c0b7@proxmox.com> <97caa32b-eb4d-434e-965c-b65d51761a41@proxmox.com> From: Dominik Csapak In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2023 14:27:01 -0000 On 12/6/23 15:04, Maximiliano Sandoval wrote: > Dominik Csapak writes: > >> it's more like DHCP, SLAAC or IPv4. those are names of protocols (like ACME) >> that shouldn't change across translations >> >> and we removed those gettexts (mostly) a while ago >> e.g. see lxc/Network.js in pve-manager: >> >> ---8<--- >> boxLabel: 'DHCP', // do not localize >> --->8--- > > Do note the following examples: yeah i said we didn't remove all of those instances and it seems there are some not so good translations still existing. (bad translations are not a good argument for translating even more of them? I'd argue they are even an argument that we should reduce them) > > #: pve-manager/www/manager6/qemu/IPConfigEdit.js:97 > #: pve-manager/www/manager6/qemu/IPConfigEdit.js:155 > msgid "DHCP" > msgstr "بروتوكول التهيئة الآلية للمضيفين (DHCP)" Does not really make sense IMO to translate this, since DHCP already is an established abbreviation and there is no need to write it out localized. > > #: pve-manager/www/manager6/qemu/IPConfigEdit.js:163 > msgid "SLAAC" > msgstr "Autoconfiguration SLAAC" IMHO this makes even less sense, SLAAC already includes 'autoconfiguration', so why do this? > > #: pve-manager/www/manager6/ceph/CephInstallWizard.js:476 > msgid "First Ceph monitor" > msgstr "أول جهاز مراقبة" doesn't mention ceph in the translation at all.... (which it should!) > > What would be the purpose of removing the translation of the words > themselves if they are already being translated elsewhere. none of the examples here translate the words in a meaningful manner, should be either already known, mentioned in the docs, or be easily searchable online. also it only causes issues when using an overly long text in a field label > > -- > Maximiliano honestly i don't want to argue/bikeshed about such a small detail, but i don't see a good reason to translate names and established (technical) words. I'm ready to change my mind, but i did not see a good example of when it would be good to translate 'ACME' (or DHCP, Ceph, etc.) into something different yet.