From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 5134C1FF15C
	for <inbox@lore.proxmox.com>; Wed, 26 Mar 2025 09:12:22 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id C61AC30E58;
	Wed, 26 Mar 2025 09:12:15 +0100 (CET)
Message-ID: <37855440-f4af-45ce-a7ac-781bb0151ed1@proxmox.com>
Date: Wed, 26 Mar 2025 09:11:42 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
 Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20250318090900.725706-1-d.csapak@proxmox.com>
 <c8235584-6863-4021-b0dc-b36dd9bcc52c@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <c8235584-6863-4021-b0dc-b36dd9bcc52c@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.022 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH] fix #6223: fit terminal after 'OK' message
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On 3/25/25 19:44, Thomas Lamprecht wrote:
> Am 18.03.25 um 10:09 schrieb Dominik Csapak:
>> instead of simply waiting 250ms after we send the credentials, wait
>> until after the server responded with 'OK' to fit the terminal size.
>> Still keep the timeout to not do that in the onmessage handler itself,
>> but rather at a later point in time.
> 
> potential dumb question, but what's the reason to keep the 250ms in
> that case?

not a dumb question at all, and you're right: the exact value of 250ms is strictly not necessary.
I wanted to keep the code in a timeout, so it does not block the 'onmessage' handler,
but rather that it runs later when the browser has idle cycles.

We could of course reduce the timeout, but in my experience, sometimes browsers behave unexpected
when it's too short (e.g., it then runs immediatly after the JS code, without a render cycle in
between, which is what i want to avoid here)

In practice, omitting the timeout here would naturally work too here, but possibly delay the content
of the terminal in favor of resizing.

Does that make sense to you?


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel