From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 50F8BBBCDA for ; Wed, 27 Mar 2024 11:32:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2C563308BD for ; Wed, 27 Mar 2024 11:32:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 27 Mar 2024 11:32:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 53EBD4252A for ; Wed, 27 Mar 2024 11:32:07 +0100 (CET) Message-ID: <36c407b3-1e93-46ae-bb56-ab6418030b42@proxmox.com> Date: Wed, 27 Mar 2024 11:32:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox VE development discussion References: <20240326132556.4050167-1-a.lauterer@proxmox.com> <88bf83e4-eb41-4682-a4db-50eed90d872f@proxmox.com> Content-Language: en-US From: Aaron Lauterer In-Reply-To: <88bf83e4-eb41-4682-a4db-50eed90d872f@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] applied: [PATCH manager] ui: guest import: allow setting mac addresses to unique X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Mar 2024 10:32:08 -0000 On 2024-03-27 11:26, Thomas Lamprecht wrote: > Am 26/03/2024 um 14:25 schrieb Aaron Lauterer: >> by adding a new checkbox and render the grid accordingly. >> >> If unique MAC addresses are enabled, set them to undefined when getting >> the values from the grid. >> >> Signed-off-by: Aaron Lauterer >> --- >> not sure if setting `uniqueMac` directly on the component is okay. >> Though we do that dynamically for the `vmConfig` as well. So probably >> okayish. >> >> www/manager6/window/GuestImport.js | 39 +++++++++++++++++++++++++++++- >> 1 file changed, 38 insertions(+), 1 deletion(-) >> >> > > applied, with a follow-up to rework this using the viewModel for tracking > the state instead of doing that in a config option of the widget, thanks! thanks! I did choose the 'labelWidth' and 'fieldLabel' to match the look and feel of the 'Prepare for Virtio-SCSI" checkbox further up for consistency though. Maybe we want to change that back?