From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3072D1FF173 for ; Mon, 11 Nov 2024 13:33:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6B280A4CA; Mon, 11 Nov 2024 13:33:34 +0100 (CET) Message-ID: <369a423b-57d7-4ad5-a9f8-4b758ca55c75@proxmox.com> Date: Mon, 11 Nov 2024 13:33:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Fiona Ebner , pve-devel@lists.proxmox.com References: <20240802115322.71114-1-f.ebner@proxmox.com> <23ced8c2-9e15-4e86-adea-85f51e8d5769@proxmox.com> <75bd9a19-1194-4a9b-9191-b3ead256e152@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <75bd9a19-1194-4a9b-9191-b3ead256e152@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.645 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH common] inotify: avoid cyclic use statement X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 11/11/24 13:10, Fiona Ebner wrote: >>> The rest of the PVE::INotify module alredy uses syslog(), which could >>> be used here as well to get rid of the cyclic usage. Wolfgang argued >>> that the whole point of commit e68ebda was to remove coupling between >>> the name and the type of the interface. If there still is some code >>> about a name starting with 'vmbr' being classified wrong, that should >>> rather be fixed. Because of the very commit, the frontend already >>> doesn't show e.g. a non-bridge with name 'vmbr7' in bridge selectors. > > If we keep it, syslog() is better than warn here. But why is it better > for the check to be there than not (like Wolfgang suggested)? It was intended as a safety net, so we can catch potentially odd setups. Iirc no one ever reported seeing that warning, so I guess it passed the scream test. So, removing this check is fine by me. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel