From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 294851FF2AD for ; Thu, 4 Jul 2024 14:37:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 964863260B; Thu, 4 Jul 2024 14:37:59 +0200 (CEST) Message-ID: <368df55b-9cb7-49fc-a1e0-768975a7e692@proxmox.com> Date: Thu, 4 Jul 2024 14:37:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pve-devel@lists.proxmox.com References: <20240529132526.272941-1-s.hanreich@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <20240529132526.272941-1-s.hanreich@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.642 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox-firewall 1/1] service: flush firewall rules on force disable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" superseded by: https://lists.proxmox.com/pipermail/pve-devel/2024-July/064439.html On 5/29/24 15:25, Stefan Hanreich wrote: > When disabling the nftables firewall again, there is a race condition > where the nftables ruleset never gets flushed and persists after > disabling. In practice this almost never happens due to pve-firewall > running every 10 seconds, and proxmox-firewall running every 5 > seconds, so the proxmox-firewall main loop almost always runs at least > once before the force disable file gets created and flushes the > ruleset. > > Reported-by: Hannes Laimer > Signed-off-by: Stefan Hanreich > --- > proxmox-firewall/src/bin/proxmox-firewall.rs | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/proxmox-firewall/src/bin/proxmox-firewall.rs b/proxmox-firewall/src/bin/proxmox-firewall.rs > index f7e816e..5133cbf 100644 > --- a/proxmox-firewall/src/bin/proxmox-firewall.rs > +++ b/proxmox-firewall/src/bin/proxmox-firewall.rs > @@ -91,6 +91,10 @@ fn main() -> Result<(), std::io::Error> { > > while !term.load(Ordering::Relaxed) { > if force_disable_flag.exists() { > + if let Err(error) = remove_firewall() { > + log::error!("unable to disable firewall: {error:#}"); > + } > + > std::thread::sleep(Duration::from_secs(5)); > continue; > } _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel