From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3AF5692CCF for ; Wed, 14 Sep 2022 16:15:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 264322D3EE for ; Wed, 14 Sep 2022 16:15:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 14 Sep 2022 16:15:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F027A441FF for ; Wed, 14 Sep 2022 16:15:19 +0200 (CEST) Message-ID: <36389dfd-5aaa-5c83-defd-4ad0b9587d6d@proxmox.com> Date: Wed, 14 Sep 2022 16:15:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 From: Aaron Lauterer To: Proxmox VE development discussion , Dominik Csapak References: <20220621092012.1776825-1-d.csapak@proxmox.com> <20220621092012.1776825-25-d.csapak@proxmox.com> Content-Language: en-US In-Reply-To: <20220621092012.1776825-25-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.764 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.583 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager v7 14/14] ui: form/Tag(Edit): add drag & drop when editing tags X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2022 14:15:21 -0000 On 6/21/22 11:20, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > www/manager6/form/Tag.js | 22 +++++++-- > www/manager6/form/TagEdit.js | 96 +++++++++++++++++++++++++++++++++++- > 2 files changed, 114 insertions(+), 4 deletions(-) > > diff --git a/www/manager6/form/Tag.js b/www/manager6/form/Tag.js > index 91190051..dcbd9597 100644 > --- a/www/manager6/form/Tag.js > +++ b/www/manager6/form/Tag.js > @@ -31,6 +31,9 @@ Ext.define('Proxmox.Tag', { > if (event.target.tagName !== 'I') { > return; > } > + if (event.target.classList.contains('handle')) { > + return; > + } > switch (me.mode) { > case 'editable': > if (me.addTag) { > @@ -156,12 +159,14 @@ Ext.define('Proxmox.Tag', { > let text = me.tag; > let cursor = 'pointer'; > let padding = '0px'; > + let dragHandleStyle = 'none'; > switch (mode) { > case 'normal': > iconStyle += 'display: none;'; > padding = undefined; > break; > case 'editable': > + dragHandleStyle = ''; Is there a reason for the '' here compared to the 'none' above and below? > break; > case 'edit': > me.tagEl().contentEditable = true; > @@ -174,12 +179,14 @@ Ext.define('Proxmox.Tag', { > if (me.addTag) { > me.setText(text); > me.setStyle('cursor', cursor); > + dragHandleStyle = 'none'; > } [...]