From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3F3947EA07 for ; Thu, 11 Nov 2021 11:21:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3D1598E7D for ; Thu, 11 Nov 2021 11:21:45 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 43A378E6F for ; Thu, 11 Nov 2021 11:21:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1832942775 for ; Thu, 11 Nov 2021 11:21:44 +0100 (CET) Message-ID: <361b1246-9caf-5b7e-3497-87e84bba74d2@proxmox.com> Date: Thu, 11 Nov 2021 11:21:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:95.0) Gecko/20100101 Thunderbird/95.0 Content-Language: en-US To: Proxmox VE development discussion , Stoiko Ivanov References: <20211110152510.3979872-1-s.ivanov@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20211110152510.3979872-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.134 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH pve-kernel-meta v2] proxmox-boot: read only first line of /etc/kernel/cmdline X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2021 10:21:45 -0000 On 10.11.21 16:25, Stoiko Ivanov wrote: > following the commit of removing the wrong indentation of the linux > and initrd lines - this commit strips empty lines (and leading > trailing whitespace) in /etc/kernel/cmdline. > > I managed to reproduce the issue reported in the forum [0] by adding > empty lines to /etc/kernel/cmdline) - without this - systemd-boot > booted quite happily even with the indentation. > > considered using perl -pe with multiline matching but thanks to > Thomas' suggestion went with the shell-builtin read. > > the check for existance of 'root=' in the resulting CMDLINE was added, > since my test-system had an empty line in the beginning, which again > rendered it unbootable. > > quickly tested on a VM. > > [0]: https://forum.proxmox.com/threads/problem-with-proxmox-boot-tool.99043/ > > Signed-off-by: Stoiko Ivanov > --- > v1->v2: > * incorporated Dominik and Thomas' feedback (huge thanks for catching my > glitches!) > > proxmox-boot/zz-proxmox-boot | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > applied, thanks! I'd have preferred for this being two separate patches though.