From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path:
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 6B2679BDB3
for ; Tue, 21 Nov 2023 14:28:47 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 4F003A3E7
for ; Tue, 21 Nov 2023 14:28:47 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for ; Tue, 21 Nov 2023 14:28:46 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 530E341671
for ; Tue, 21 Nov 2023 14:28:46 +0100 (CET)
Message-ID: <35eec185-4457-443e-aa15-3a0a5940ddb4@proxmox.com>
Date: Tue, 21 Nov 2023 14:28:45 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: pve-devel@lists.proxmox.com
References: <20231121125240.158044-1-l.wagner@proxmox.com>
From: Philipp Hufnagl
In-Reply-To: <20231121125240.158044-1-l.wagner@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.051 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: Re: [pve-devel] [PATCH v4 manager 0/4] vzdump: add
'notification-mode' parameter
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
X-List-Received-Date: Tue, 21 Nov 2023 13:28:47 -0000
On 11/21/23 13:52, Lukas Wagner wrote:
> This patch series adds the 'notification-mode' setting for backup jobs.
> It allows users to choose between the 'old-style' notifications
> (mail to configured address, directly via a call to sendmail) or
> the 'new-style' notification system.
>
> notification-mode has three possible values:
> - legacy-sendmail: Use old system, considering mailto/mailtnotification parameters
> - notification-system: Use the new system (always sending a notification, irregardless
> of success/failure. The user is supposed to configure filtering/matching in
> notification settings)
> - auto: use old system if mailto is set, or new system if not
>
> This should provide a fix/workaround for the users' reports of
> - double notifications (these happened in case mailto was set to the same address
> as root@pam)
> - notifications always being sent, even if 'mailnotification' is set to failure
>
> Changes v2 -> v3:
> - change field text in the GUI for the 'mailnotification' param
> This should highlight that this setting only affects the 'legacy-sendmail'
> notification mails
>
> Changes v3 -> v4:
> - fix eslint warnings (thx @Philipp)
> - drop already applied pve-guest-common patch
>
>
>
> pve-manager:
>
> Lukas Wagner (4):
> vzdump: support 'notification-mode' parameter
> ui: backup jobs: add 'notification-mode' selector for backup jobs
> ui: backup: add 'notification-mode' param for one-shot backup jobs.
> ui: backup job: change field text for 'mailnotification' field
>
> PVE/VZDump.pm | 95 +++++++++++--------
> www/manager6/dc/Backup.js | 34 ++++++-
> .../form/NotificationPolicySelector.js | 2 +-
> www/manager6/window/Backup.js | 25 +++++
> 4 files changed, 116 insertions(+), 40 deletions(-)
>
>
> Summary over all repositories:
> 4 files changed, 116 insertions(+), 40 deletions(-)
>
I do not know if this is expected but when I enter an invalid email
address for a user, and then press "Test" for SMTP, I get a message
that the email has been sent successfully, however the receiver does
not get any email and the sender account gets "Undelivered Mail
Returned to Sender".