From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2B7A21FF380 for ; Fri, 19 Apr 2024 15:11:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 73AC8991D; Fri, 19 Apr 2024 15:11:52 +0200 (CEST) Message-ID: <359b71cc-d5fa-44dc-8110-9aff124dbc64@proxmox.com> Date: Fri, 19 Apr 2024 15:11:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Lukas Wagner , Proxmox VE development discussion References: <20240415082614.2515677-1-l.wagner@proxmox.com> <20240415082614.2515677-6-l.wagner@proxmox.com> <023f8a90-8cea-42d2-b411-deaca98d4405@proxmox.com> <192a1768-ae71-42e8-bc05-45fa1b015161@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <192a1768-ae71-42e8-bc05-45fa1b015161@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v5 05/16] api: replication: add 'replication-job' to notification metadata X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 19.04.24 um 14:22 schrieb Lukas Wagner: > > > On 2024-04-19 14:02, Fiona Ebner wrote: >> Am 15.04.24 um 10:26 schrieb Lukas Wagner: >>> This allows users to create notification match rules for specific >>> replication jobs, if they so desire. >>> >>> Signed-off-by: Lukas Wagner >>> --- >>> PVE/API2/Replication.pm | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm >>> index 0dc944c9..703640f5 100644 >>> --- a/PVE/API2/Replication.pm >>> +++ b/PVE/API2/Replication.pm >>> @@ -140,8 +140,8 @@ my sub _handle_job_err { >>> }; >>> >>> my $metadata_fields = { >>> - # TODO: Add job-id? >>> type => "replication", >>> + "replication-job" => $job->{id}, >>> }; >>> >>> eval { >> >> Not sure if we should use "replication-job" and "backup-job" for the >> metadata entries rather then just "job-id". The type is already >> something that can be matched, why re-do it implicitly with the field >> name? E.g. I want to see all jobs with -fiona- on the system, now I'd >> have to create a matcher rule for each job type. > > Had a 'job-id' field at first, but I *think* (can't be too sure after more than > 4 months of not working on this) the reason why I changed it to this approach > were the replication job IDs, which look like '100-0' or similar. > Giving them and other job IDs a unique field made it a bit easier to > understand what is what when creating a matcher in the improved UI. > > For instance, if you just have 'job-id', the pre-filled combo box in the > match-field edit UI might contain these values > > - backup-gaasdgh7asdfg > - 100-0 > - 101-0 > > IMO it's a bit hard to understand that the last two are replication jobs. The separate > job fields make this easier. We know that it either starts with "backup-" (or "realmsync-", should those get notifications), or is a replication job. So we could also just display something that indicates they are replication jobs (e.g. "replication-XYZ" or "XYZ (replication)"), until we turn replication jobs into proper jobs in the backend. Otherwise, each job type we add will just have a new matcher field for its ID. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel