From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 2CB0D1FF0EA for ; Thu, 13 Aug 2026 13:13:08 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3482121578; Thu, 13 Aug 2026 13:13:06 +0200 (CEST) Message-ID: <354b35e7-01e8-4d5f-8177-f48044d1268e@proxmox.com> Date: Thu, 13 Aug 2026 13:13:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-apiclient 1/1] client: allow passing query parameters to delete calls To: Stefan Hanreich , pve-devel@lists.proxmox.com References: <20260813105200.139383-1-s.hanreich@proxmox.com> From: Hannes Laimer Content-Language: en-US In-Reply-To: <20260813105200.139383-1-s.hanreich@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786619566010 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.452 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TNXZCGJE4F2ZRXQLSQZUVY3FCL35H3J5 X-Message-ID-Hash: TNXZCGJE4F2ZRXQLSQZUVY3FCL35H3J5 X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thought this looked familiar :P On 2026-08-13 12:52, Stefan Hanreich wrote: > Some DELETE endpoints in the PVE API use additional parameters, that > are passed as a query string. The API client did not process any > parameters passed to delete calls, making it impossible to use DELETE > endpoints in the PVE API that rely on additional parameters (e.g. the > DELETE endpoint in the SDN IPAM IP module). > > Signed-off-by: Stefan Hanreich > --- > src/PVE/APIClient/LWP.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/PVE/APIClient/LWP.pm b/src/PVE/APIClient/LWP.pm > index d8472f7..216260a 100755 > --- a/src/PVE/APIClient/LWP.pm > +++ b/src/PVE/APIClient/LWP.pm > @@ -332,6 +332,7 @@ sub call { > ); > > } elsif ($method eq 'DELETE') { > + $uri->query_form($param); > $response = $ua->request(HTTP::Request::Common::DELETE($uri)); > } else { > raise("method $method not implemented\n");