From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B26B7703D4 for ; Fri, 6 May 2022 10:00:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 71017A176 for ; Fri, 6 May 2022 10:00:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C01C8A16A for ; Fri, 6 May 2022 10:00:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2270D42B90 for ; Fri, 6 May 2022 10:00:51 +0200 (CEST) Message-ID: <34ee9614-74dd-8556-3c53-84efdbeab553@proxmox.com> Date: Fri, 6 May 2022 10:00:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101 Thunderbird/101.0 Content-Language: en-GB To: Proxmox VE development discussion , Matthias Heiserer References: <20220505142709.1128710-1-m.heiserer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220505142709.1128710-1-m.heiserer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.743 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.441 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager] GUI: Ceph wizard: autoselect current node X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2022 08:00:52 -0000 Am 5/5/22 um 16:27 schrieb Matthias Heiserer: > One step of installing ceph is creating a monitor. When installing via > the datacenter and from a node other than the first node, clicking "next" > without changing the monitor node could result in the error > 'binary not installed: /usr/bin/ceph-mon', as it would try to install > the monitor on the first node, although ceph was installed on the current > node. > > With this patch, the current node is preselected. > This has no effect when installing ceph on a specific node, as the node > selector overwrites the preferred value in that case. > > Signed-off-by: Matthias Heiserer > --- > www/manager6/ceph/CephInstallWizard.js | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js > index 59458b0d..ebdc7f1d 100644 > --- a/www/manager6/ceph/CephInstallWizard.js > +++ b/www/manager6/ceph/CephInstallWizard.js > @@ -403,6 +403,7 @@ Ext.define('PVE.ceph.CephInstallWizard', { > name: 'mon-node', > selectCurNode: true, > allowBlank: false, > + preferredValue: Proxmox.NodeName, That is always the local node one is connected through the web interface. So, what if I'm connected through Node A but currently installing/initializing ceph on Node B? Should this rather be the node currently selected in the resource tree? > }, > { > xtype: 'displayfield',