From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D288291AB5; Tue, 15 Nov 2022 09:29:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B9E2734D3; Tue, 15 Nov 2022 09:29:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS; Tue, 15 Nov 2022 09:29:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 503A243DA1; Tue, 15 Nov 2022 09:29:03 +0100 (CET) Message-ID: <34c375db-45e4-05e8-6bfa-373c951149bb@proxmox.com> Date: Tue, 15 Nov 2022 09:29:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 Content-Language: en-GB To: Proxmox Backup Server development discussion , Dominik Csapak , pve-devel@lists.proxmox.com References: <20221110103634.2177856-1-d.csapak@proxmox.com> <20221110103634.2177856-2-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221110103634.2177856-2-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: =?UTF-8?Q?0=0A=09?=AWL -0.032 Adjusted score from AWL reputation of From: =?UTF-8?Q?address=0A=09?=BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict =?UTF-8?Q?Alignment=0A=09?=SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF =?UTF-8?Q?Record=0A=09?=SPF_PASS -0.001 SPF: sender matches SPF =?UTF-8?Q?record=0A=09?=URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [main.rs] Subject: [pve-devel] applied: [pbs-devel] [PATCH proxmox-backup v4 1/1] file-restore: make dynamic memory behaviour controllable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Nov 2022 08:29:10 -0000 Am 10/11/2022 um 11:36 schrieb Dominik Csapak: > by adding 'dynamic-memory' parameter that controls if we automatically > increase the memory of the guest vm or not > > Signed-off-by: Dominik Csapak > --- > new in v4 > > not really happy with the 'clippy allow', but imho there is no obvious way to > bundle those parameters without restructuring the code much > > proxmox-file-restore/src/block_driver.rs | 10 +++- > proxmox-file-restore/src/block_driver_qemu.rs | 6 ++- > proxmox-file-restore/src/main.rs | 54 +++++++++++++++++-- > 3 files changed, 61 insertions(+), 9 deletions(-) > > applied, but superseeded looping thorugh a new param over quite a few function by getting this out from the PBS_FILE_RESTORE_MEM_HOTPLUG_ALLOW environment variable being set to "true", thanks! Note that I also made a few other followups to that code, e.g., introducing QMPSock to avoid having QMP internals in a rather unrelated function, among other things.