From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E824F9343E for ; Tue, 9 Apr 2024 09:55:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C7F3F17B36 for ; Tue, 9 Apr 2024 09:55:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 9 Apr 2024 09:55:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A1DD942BB4 for ; Tue, 9 Apr 2024 09:55:08 +0200 (CEST) Message-ID: <34301e94-933e-4843-a8b1-bec187fd5402@proxmox.com> Date: Tue, 9 Apr 2024 09:55:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Thomas Lamprecht , Stefan Sterz References: <20240408093019.109137-1-f.weber@proxmox.com> <868ec1d0-6c32-4fa6-8652-e80e985d077e@proxmox.com> Content-Language: en-US From: Friedrich Weber In-Reply-To: <868ec1d0-6c32-4fa6-8652-e80e985d077e@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH widget-toolkit v3] window: edit: avoid sharing custom config objects between subclasses X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2024 07:55:11 -0000 On 08/04/2024 14:36, Thomas Lamprecht wrote: > Am 08/04/2024 um 12:36 schrieb Stefan Sterz: >> [...] >> so, this seems like a fix bug a) creates bug b) type of situation... >> this patch means that editing a pool allows changing the name suddenly, >> but since we don't support that in the backend, that just creates a new >> pool :/ >> >> this is due to the `editable` attribute depending on `isCreate`, which >> in turn depends on the configs poolid being set. to fix this, the config >> needs to also be passed to `callParent` so it can set the configurations >> there too. so this line should be: >> >> me.callParent([conf]); >> >> sorry, could have noticed that earlier in my suggestion. also this needs >> to be an arrray as `callParent` expects a list of arguments to pass to >> parent's function and not the parameters themselves directly. > > Using `me.callParent(arguments)` might be more proof to future changes and > arguments is an array (or well, iterator) already Thanks for spotting this, missed that during testing. Will send a v4.