From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D9AB291877 for ; Tue, 30 Jan 2024 13:32:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B0F571E2A8 for ; Tue, 30 Jan 2024 13:31:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 30 Jan 2024 13:31:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D89BA492EC for ; Tue, 30 Jan 2024 13:31:41 +0100 (CET) Message-ID: <338f2b7f-3cea-4339-82da-bdd6e4a4839a@proxmox.com> Date: Tue, 30 Jan 2024 13:31:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Markus Frank , Proxmox VE development discussion References: <20231108085254.53574-1-m.frank@proxmox.com> Content-Language: en-US From: Markus Frank In-Reply-To: <20231108085254.53574-1-m.frank@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v8 0/7] virtiofs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jan 2024 12:32:12 -0000 ping, patches still apply. Only the cluster patch needs a 3-way merge to apply. On 2023-11-08 09:52, Markus Frank wrote: > build-order: > 1. cluster > 2. guest-common > 3. docs > 4. qemu-server > 5. manager > > I did not get virtiofsd to run with run_command without creating zombie > processes after stutdown. > So I replaced run_command with exec for now. > Maybe someone can find out why this happens. > > > cluster: > > Markus Frank (1): > add mapping/dir.cfg for resource mapping > > src/PVE/Cluster.pm | 1 + > src/pmxcfs/status.c | 1 + > 2 files changed, 2 insertions(+) > > > guest-common: > > v7: > * renamed DIR to Dir > * made xattr & acl settings per directory-id and not per node > > Markus Frank (1): > add Dir mapping config > > src/Makefile | 1 + > src/PVE/Mapping/Dir.pm | 177 +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 178 insertions(+) > create mode 100644 src/PVE/Mapping/Dir.pm > > > docs: > > v8: > * added "Known Limitations" > * removed old mount tag > > Markus Frank (1): > added shared filesystem doc for virtio-fs > > qm.adoc | 84 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 82 insertions(+), 2 deletions(-) > > > qemu-server: > > v8: > * changed permission checks to cover cloning and restoring and > made the helper functions similar to the PCI, USB permission check functions. > * warn if acl is activated on Windows VM, since the virtiofs device cannot be > mounted on Windows if acl is on and moved with dir config validation to > its own function. This function is called in config_to_command so that > no virtiofsd command is running although qmstart died because a second > virtiofs device was incorrectly configured. > > v7: > * enabled use of hugepages > * renamed variables > * added acl & xattr parameters that overwrite the default directory > mapping settings > > v6: > * added virtiofsd dependency > * 2 new patches: > * Permission check for virtiofs directory access > * check_local_resources: virtiofs > > v5: > * allow numa settings with virtio-fs > * added direct-io & cache settings > * changed to rust implementation of virtiofsd > * made double fork and closed all file descriptor so that the lockfile > gets released. > > v3: > * created own socket and get file descriptor for virtiofsd > so there is no race between starting virtiofsd & qemu > * added TODO to replace virtiofsd with rust implementation in bookworm > (I packaged the rust implementation for bookworm & the C implementation > in qemu will be removed in qemu 8.0) > > v2: > * replaced sharedfiles_fmt path in qemu-server with dirid: > * user can use the dirid to specify the directory without requiring root access > > Markus Frank (3): > feature #1027: virtio-fs support > Permission check for virtiofs directory access > check_local_resources: virtiofs > > PVE/API2/Qemu.pm | 39 ++++++- > PVE/QemuServer.pm | 200 ++++++++++++++++++++++++++++++++++- > PVE/QemuServer/Memory.pm | 25 +++-- > debian/control | 1 + > test/MigrationTest/Shared.pm | 7 ++ > 5 files changed, 263 insertions(+), 9 deletions(-) > > > manager: > > v8: removed ui patches for now > > Markus Frank (1): > api: add resource map api endpoints for directories > > PVE/API2/Cluster/Mapping.pm | 7 + > PVE/API2/Cluster/Mapping/Dir.pm | 309 ++++++++++++++++++++++++++++++ > PVE/API2/Cluster/Mapping/Makefile | 3 +- > 3 files changed, 318 insertions(+), 1 deletion(-) > create mode 100644 PVE/API2/Cluster/Mapping/Dir.pm >