From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 47E25A286A for ; Mon, 19 Jun 2023 14:21:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9F86F292E2 for ; Mon, 19 Jun 2023 14:21:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 19 Jun 2023 14:21:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 54E4446863 for ; Mon, 19 Jun 2023 14:21:06 +0200 (CEST) Message-ID: <337bff5b-d10f-d2e0-ca15-fb6da17e7a51@proxmox.com> Date: Mon, 19 Jun 2023 14:21:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Proxmox VE development discussion , Aaron Lauterer References: <20230619092937.604628-1-a.lauterer@proxmox.com> From: Fiona Ebner In-Reply-To: <20230619092937.604628-1-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.09 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v5 qemu-server 0/7] migration: don't scan all storages, fail on aliases X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2023 12:21:08 -0000 Am 19.06.23 um 11:29 schrieb Aaron Lauterer: > This patch series changes the behavior during guest migrations: > > Don't scan all storages for potential images belonging to the guest. > Only migrate images referenced in the config. > This made it necessary to handle pending changes explicitly which had > been covered by the storage scan. > > We also added checks for any aliased volids and fail the migration if > detected. > > The qemu-server part consists of quite a lot more commits since we had > to change a few things and for a better history, they are mostly their > own patches. > > There is also a small patch for the documentation to add a hint that > aliased storages should be avoided. > > Looks good to me so far. Just three minor nits remaining (see replies to individual patches), but those don't warrant a new version by themselves and can be fixed upon/after applying. For the patches that don't have it yet: Reviewed-by: Fiona Ebner