From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A2BAF1FF17A for ; Tue, 28 Oct 2025 13:19:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 529F719D57; Tue, 28 Oct 2025 13:20:07 +0100 (CET) Message-ID: <3377baa2-e708-4d7e-a96d-9ae42ccb7f0e@proxmox.com> Date: Tue, 28 Oct 2025 13:19:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Friedrich Weber References: <20251024122705.93761-1-f.weber@proxmox.com> <20251024122705.93761-3-f.weber@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20251024122705.93761-3-f.weber@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761653961002 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-storage 2/2] plugin: rbd: pass rxbounce when mapping Windows VM disks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 24.10.25 um 2:27 PM schrieb Friedrich Weber: > rxbounce can be needed to avoid "bad crc/signature" errors when > running Windows VM disks on KRBD. When mapping a volume, check > the guest-ostype hint, and if it denotes the volume is mapped > as part of a Windows VM, pass rxbounce. > > Signed-off-by: Friedrich Weber > --- > src/PVE/Storage/RBDPlugin.pm | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/src/PVE/Storage/RBDPlugin.pm b/src/PVE/Storage/RBDPlugin.pm > index cf371c7..54c5a57 100644 > --- a/src/PVE/Storage/RBDPlugin.pm > +++ b/src/PVE/Storage/RBDPlugin.pm > @@ -793,7 +793,7 @@ sub deactivate_storage { > } > > sub map_volume { > - my ($class, $storeid, $scfg, $volname, $snapname) = @_; > + my ($class, $storeid, $scfg, $volname, $snapname, $hints) = @_; > > my ($vtype, $img_name, $vmid) = $class->parse_volname($volname); > > @@ -807,7 +807,12 @@ sub map_volume { > # features can only be enabled/disabled for image, not for snapshot! > $krbd_feature_update->($scfg, $storeid, $img_name); > > - my $cmd = $rbd_cmd->($scfg, $storeid, 'map', $name); > + my @options = (); > + if (defined($hints->{'guest-ostype'}) && $hints->{'guest-ostype'} =~ /^w/) { As already said in the last patch, this is a no-go. The RBD plugin should not be concerned with knowing how qemu-server defines (Windows) guest OS types. > + @options = ('--options', 'rxbounce'); > + } > + > + my $cmd = $rbd_cmd->($scfg, $storeid, 'map', $name, @options); > run_rbd_command($cmd, errmsg => "can't map rbd volume $name"); > > return $kerneldev; > @@ -830,9 +835,9 @@ sub unmap_volume { > } > > sub activate_volume { > - my ($class, $storeid, $scfg, $volname, $snapname, $cache) = @_; > + my ($class, $storeid, $scfg, $volname, $snapname, $cache, $hints) = @_; > > - $class->map_volume($storeid, $scfg, $volname, $snapname) if $scfg->{krbd}; > + $class->map_volume($storeid, $scfg, $volname, $snapname, $hints) if $scfg->{krbd}; > > return 1; > } _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel