From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8A258641EB for ; Thu, 29 Oct 2020 19:14:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 79083BA8D for ; Thu, 29 Oct 2020 19:13:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 00EBDBA82 for ; Thu, 29 Oct 2020 19:13:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BA70945F96 for ; Thu, 29 Oct 2020 19:13:41 +0100 (CET) To: Proxmox VE development discussion , Stefan Reiter References: <20201022153420.16971-1-s.reiter@proxmox.com> From: Thomas Lamprecht Message-ID: <3352a1e6-caf7-0c78-7689-4ef541b99908@proxmox.com> Date: Thu, 29 Oct 2020 19:13:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201022153420.16971-1-s.reiter@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.124 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lib.rs, qemuserver.pm, commands.rs] Subject: [pve-devel] applied-series: [PATCH 0/4] Keep dirty-bitmaps for PBS during migration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2020 18:14:12 -0000 On 22.10.20 17:34, Stefan Reiter wrote: > Allow dirty bitmaps to persist over a live migration, allowing incremen= tal > backups even after a VM has been moved to another node. >=20 > Migrating the dirty-bitmaps themselves is supported natively by QEMU, o= nly > requiring a fix for a bug leading to hangs when migrating bitmaps with = a > granularity as low as we are using (see first patch). >=20 > The second and third patches are the interesting bits, implementing > "savevm"-style migration for all PBS state that is being kept in memory= > (checksums). >=20 > The last patch brings it all together by enabling it in qemu-server whe= n support > is detected (which is important, since we never want to enable "dirty-b= itmaps" > capability on unpatched versions of QEMU, as that will lead to unrecove= rable VM > hangs). >=20 > Compatility is maintained between all pve-qemu-kvm and qemu-server vers= ions, > with the usual exception of not being able to migrate VMs started with = a newer > QEMU version to a machine with an older one. >=20 >=20 > qemu: Stefan Reiter (2): > migration/block-dirty-bitmap: fix larger granularity bitmaps > PVE: Migrate dirty bitmap state via savevm >=20 > include/migration/misc.h | 3 ++ > migration/Makefile.objs | 1 + > migration/block-dirty-bitmap.c | 3 +- > migration/pbs-state.c | 92 ++++++++++++++++++++++++++++++++++= > pve-backup.c | 1 + > qapi/block-core.json | 9 +++- > softmmu/vl.c | 1 + > 7 files changed, 108 insertions(+), 2 deletions(-) > create mode 100644 migration/pbs-state.c >=20 > proxmox-backup-qemu: Stefan Reiter (1): > add state serializing and loading functions >=20 > Cargo.toml | 1 + > current-api.h | 20 ++++++++++++++++++++ > src/commands.rs | 19 +++++++++++++++++++ > src/lib.rs | 34 ++++++++++++++++++++++++++++++++++ > 4 files changed, 74 insertions(+) >=20 > qemu-server: Stefan Reiter (1): > migrate: enable dirty-bitmap migration >=20 > PVE/QemuServer.pm | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 applied remaining parts of the series, thanks!