From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id D454F1FF0AE for ; Tue, 01 Sep 2026 16:20:31 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E473B2092E; Tue, 01 Sep 2026 16:20:30 +0200 (CEST) Message-ID: <32a722b1-f8a4-4f3d-b7f7-e1ab0cd1336b@proxmox.com> Date: Tue, 1 Sep 2026 16:20:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: David Riley Subject: Re: [PATCH docs/manager/qemu-server 0/6] fix #7213: add `powercycle` reboot behavior To: Jakob Klocker , pve-devel@lists.proxmox.com References: <20260813112717.272254-1-j.klocker@proxmox.com> Content-Language: en-US In-Reply-To: <20260813112717.272254-1-j.klocker@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788272423797 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.819 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5BD7WCFVWPMSKC2ELIPIB75YAHKVC5JD X-Message-ID-Hash: 5BD7WCFVWPMSKC2ELIPIB75YAHKVC5JD X-MailFrom: d.riley@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for tackling this quality of life feature! Applied the patches and tested it on a HA-Cluster. Made sure the following works: - Reboot from within the guest (with powercycle=1) successfully applies   pending hardware changes. - HA-Manager (self-fence), migration, and starting of workloads still work   as expected. - Migrated between a patched (reboot: 1,powercycle=1) and unpatched   node and everything seems to work. In the log there is this message:   [pve-node-5] vm 103 - unable to parse value of 'reboot' - type check ('boolean') failed - got '1,powercycle=1'   On the unpatched node the 'reboot: 1' will be missing, in this case it is not   a big deal as 'reboot: 1' is the default value, but when 'reboot: 0,powercycle=1'   is set it will get lost when migrating. Not a big deal just something to be   aware of. Overall, everything seems to work as intended. I do have one suggestion which might be worth addressing: Reboot Button in the WebUI: It would be a nice addition to add a warning in the task log when using the "Reboot" button on a VM where 'reboot: 0' is set. Since this setting is now exposed in the UI, a user might be confused as to why the VM simply shuts down instead of restarting when a reboot is issued. Found a few small nits on Patch 5/6, but consider this: Tested-by: David Riley On 8/13/26 1:28 PM, Jakob Klocker wrote: > A reboot initiated inside the guest is handled by QEMU itself: the > process keeps running and only the guest OS boots again. That is fast, > but the VM stays on the configuration and QEMU binary it was started > with, so pending changes remain pending. > > This series adds a `powercycle` sub-property to the existing `reboot` > option. With it set, the VM is started with `-no-reboot`, so QEMU exits > on a reset; qmeventd reports the reason, and `qm cleanup` starts > the VM again. The result is a full start, so pending changes take > effect. > > To carry the new sub-property, `reboot` is converted to a property > string. Existing configurations stay valid, as the previous boolean > value is the default key. > > Note two behavior changes beyond the new sub-property: `reboot: 0` now > also prevents a restart for reboots triggered through the web interface, > `qm` or the API - previously only guest-initiated reboots were affected. > The documented meaning of the option is that the VM does not reboot, so > this seemed like the more consistent reading. And with `powercycle` set, > a reset requested through the web interface, `qm` or the API also becomes > a full stop and start, since `-no-reboot` makes QEMU exit on any reset. > > Link:https://bugzilla.proxmox.com/show_bug.cgi?id=7213 > > > qemu-server: > > Jakob Klocker (4): > qm: do not restart VM when 'reboot' is disabled > fix #7213: config: add `powercycle` sub-property to `reboot` > fix #7213: qm: cleanup: add `reset` parameter to honor `powercycle` > fix #7213: qmeventd: pass `reset` to `qm cleanup` > > src/PVE/CLI/qm.pm | 22 +++++++++++++++++++--- > src/PVE/QemuServer.pm | 41 ++++++++++++++++++++++++++++++++++++----- > src/qmeventd/qmeventd.c | 36 ++++++++++++++++++++++++++++-------- > src/qmeventd/qmeventd.h | 1 + > 4 files changed, 84 insertions(+), 16 deletions(-) > > > pve-manager: > > Jakob Klocker (1): > ui: qemu: options: add editor for reboot behavior > > www/manager6/Makefile | 1 + > www/manager6/Utils.js | 17 +++++++ > www/manager6/form/RebootFeatureSelector.js | 59 ++++++++++++++++++++++ > www/manager6/qemu/Options.js | 14 +++++ > 4 files changed, 91 insertions(+) > create mode 100644 www/manager6/form/RebootFeatureSelector.js > > > pve-docs: > > Jakob Klocker (1): > qm: add reboot behavior information > > qm.adoc | 37 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > > Summary over all repositories: > 9 files changed, 212 insertions(+), 16 deletions(-) >