From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 541311FF142 for ; Mon, 16 Mar 2026 10:35:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2B6A813707; Mon, 16 Mar 2026 10:35:51 +0100 (CET) Message-ID: <324d2c99-dc6e-4c4e-a973-6ddbd3d1826f@proxmox.com> Date: Mon, 16 Mar 2026 10:35:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server] api: qmclone: print a message with new VMID To: Maximiliano Sandoval , pve-devel@lists.proxmox.com References: <20260316090712.106468-1-m.sandoval@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260316090712.106468-1-m.sandoval@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773653705201 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BHFEDQHVCF6BRYHXFRIKHF5VEPZVNGFN X-Message-ID-Hash: BHFEDQHVCF6BRYHXFRIKHF5VEPZVNGFN X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 16.03.26 um 10:06 AM schrieb Maximiliano Sandoval: > When doing a linked clone of a template, the task log, journal, nor the > UPID of the task will log the VMID of the newly created VM. > > We add a log message right before writing the config. This affects both > full and linked clones. > I wonder if it should rather be done at the very beginning of the task? Then you also know what the intended ID was for a failed task, which maybe could help with tracking left-overs from the operation. Note that the configuration is already written after each disk, not just at the very end. > Signed-off-by: Maximiliano Sandoval > --- > > Notes: > Note that when creating linked clones we do not update the creation time > in the config. > > When cloning two VMs from a template (created with "vanilla" settings), > if one uses the same 'name' for both clones, then the only differences > between the linked clones that could be used to tell them apart are the > MAC address, the VM id, smbios UUID, and the vmgenid, all of which are > randomly generated. > > I think it makes sense to update the creation time too. But for now, See: https://bugzilla.proxmox.com/show_bug.cgi?id=6156 https://git.proxmox.com/?p=qemu-server.git;a=commit;h=26b443c8461b3ddccffc944897af6d67a96ed7bd > being able to tell from the task log which VM correspond to which > qmclone task would be an improvement already. > > Tested: > - create a template with id 101 > - running qm clone 101 202 --full 0 and checked the output: > > create linked clone of drive scsi0 (local-lvm:base-101-disk-0) > writing configuration of cloned VM with ID 202 > > src/PVE/API2/Qemu.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm > index 1e226f6f..43e56837 100644 > --- a/src/PVE/API2/Qemu.pm > +++ b/src/PVE/API2/Qemu.pm > @@ -4589,6 +4589,7 @@ __PACKAGE__->register_method({ > delete $newconf->{pending}; > } > > + print("writing configuration of clone with ID $newid\n"); > PVE::QemuConfig->write_config($newid, $newconf); > > PVE::QemuServer::Network::create_ifaces_ipams_ips($newconf, $newid);