From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 156941FF15C for <inbox@lore.proxmox.com>; Fri, 2 May 2025 14:13:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D398C3007A; Fri, 2 May 2025 14:13:38 +0200 (CEST) Message-ID: <31df6e00-1bc0-4983-8f7e-4101604cdd50@proxmox.com> Date: Fri, 2 May 2025 14:13:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Markus Frank <m.frank@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20250428101732.27679-1-f.ebner@proxmox.com> <01768d6c-227f-4d31-93de-cc752b8ebf07@proxmox.com> Content-Language: en-US From: Fiona Ebner <f.ebner@proxmox.com> In-Reply-To: <01768d6c-227f-4d31-93de-cc752b8ebf07@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.036 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server] virtiofs: prevent issue with Windows OS and too many files X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Am 02.05.25 um 13:52 schrieb Markus Frank: > On 2025-04-28 12:17, Fiona Ebner wrote: >> As reported in the community forum [0] and the virtio-win project [1], >> virtiofsd will run into its open file limit when used with a Windows >> guest that reads too many files. It's also reported that the issue >> does not occur with Linux guests and a workaround is using >> '--inode-file-handles=mandatory' on virtiofsd command line. > I was able to reproduce the issue with a directory containing a million > files. > The virtiofs share became unusable when I tried to list the files with > 'ls'. > This patch allows to list all the files without problems. >> >> The option is described as follows in the vritiofsd help: > typo: virtiofsd Will fix! >> >>> When to use file handles to reference inodes instead of O_PATH file >>> descriptors (never, prefer, mandatory) >> >> and the default is 'never'. >> >> Fix the above issue by using 'prefer' rather than 'mandatory', because >> that should not break other edge cases: >> >>> prefer: Attempt to generate file handles, but fall back to O_PATH >>> file descriptors where the underlying filesystem does not support >>> file handles. Useful when there are various different filesystems >>> under the shared directory and some of them do not support file >>> handles. >> >> [0]: https://forum.proxmox.com/threads/165565/ >> [1]: https://github.com/virtio-win/kvm-guest-drivers-windows/issues/1136 >> >> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com> > Tested-by: Markus Frank <m.frank@proxmox.com> >> --- >> >> Didn't get around to measure the performance impact yet, so feel free >> to check that if you test this patch. While not being broken is more >> important than good performance, it would still be good to know for >> completeness. > I made a few read/write tests with fio in a Windows 11 guest. Since the option affects file handles, it would be more interesting to test something that involves handling many files rather than just IO. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel