From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 234DB5B972 for ; Tue, 7 Jul 2020 17:02:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 166732965B for ; Tue, 7 Jul 2020 17:02:04 +0200 (CEST) Received-SPF: pass (proxmox.com: 212.186.127.180 is authorized to use 't.lamprecht@proxmox.com' in 'mfrom' identity (mechanism 'mx' matched)) receiver=firstgate.proxmox.com; identity=mailfrom; envelope-from="t.lamprecht@proxmox.com"; helo=proxmox-new.maurer-it.com; client-ip=212.186.127.180 Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 677C42964D for ; Tue, 7 Jul 2020 17:02:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 16F004318F for ; Tue, 7 Jul 2020 17:02:03 +0200 (CEST) To: Proxmox VE development discussion , Mira Limbeck References: <20200707141454.2484-1-m.limbeck@proxmox.com> From: Thomas Lamprecht Message-ID: <31d7d207-73d4-2332-6b97-fd12604b09c9@proxmox.com> Date: Tue, 7 Jul 2020 17:02:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.0 MIME-Version: 1.0 In-Reply-To: <20200707141454.2484-1-m.limbeck@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [iscsiplugin.pm] Subject: [pve-devel] applied: Re: [PATCH storage] fix #2460: use dm-uuid-mpath- as fallback for multipath X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2020 15:02:34 -0000 On 07.07.20 16:14, Mira Limbeck wrote: > With Debian Buster it looks like the 'scsi-' method is no longer > reliable. In addition to that, which is also used for non-multipath > systems, add the 'dm-uuid-mpath-' method as fallback. This is also used > by openstack (see os-brick > https://github.com/openstack/os-brick/blob/39b201160bbff39117fca46b2709ff3f74c53d80/os_brick/initiator/linuxscsi.py#L400) > > Also sort the output of readdir so 'scsi-' is always after > 'dm-uuid-mpath-' so the output of pvesm list does not change for systems > that worked before. > > Signed-off-by: Mira Limbeck > --- > PVE/Storage/ISCSIPlugin.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applied, thanks!